The % simply returns the remainder of the division of the first and second number.
So if i = 25, then 25 % 2 would return 5, which doesn't meet either of your if statements.
Change your code to this:
Console.WriteLine("");
Console.WriteLine("Problem #3 For loop - Add Up the Odds or Evens");
Console.WriteLine("");
Console.WriteLine("Please select 1 for the sum of even numbers or select 2 for sum of odd numbers");
string usrin = Console.ReadLine();
int usrinnum = int.Parse(usrin);
int sumeven = 0;
int sumodd = 0;
int[] Numbers = new int[6] { 25, 26, 27, 28, 29, 30 };
if (usrinnum == 1)
{
foreach (int i in Numbers)
{
if (i % 2 == 0)
sumeven += i;
Console.WriteLine("The sum of the Evens is " + sumeven);
}
}
else
{
foreach (int i in Numbers)
{
if (i % 2 != 0)
sumodd += i;
Console.WriteLine("The Sum of the odds is " + sumodd);
}
}
Read here: https://msdn.microsoft.com/en-us/library/0w4e0fzs.aspx