make my program simple - Page 2

Question

DarkLightning7 12 Junior Poster in Training

11 Years Ago

Are you sure you copied what I gave you exactly? i tested the program before posting it to make sure i found all the problems. It should work as is.

also the stack trace doesnt do any good if i dont know where line 44 and 64 are.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

uknown2 -4 Junior Poster in Training · Answer 1 · 2013-02-21T17:42:28+00:00

I am now recieveing this error. I updated evrything.
** choice=scan.nextchar(); ** that bit code just always comes up red

MENU 
A) Add Guest
V) View All Rooms
Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - Erroneous sym type: java.util.Scanner.nextchar
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
    at hotelprogram.Hotelprogram.main(Hotelprogram.java:33)
R) View Rooms Alphabetically
E) Exit program
Choice: Choice: Java Result: 1
BUILD SUCCESSFUL (total time: 2 seconds)

uknown2 -4 Junior Poster in Training · Answer 2 · 2013-02-21T17:45:33+00:00

String names[]=new String[0];
        int rooms[]=new int[0];

The code above says the variable is not in use do i need to move this somewhere? I have used the variables in the method coding

DarkLightning7 12 Junior Poster in Training · Answer 3 · 2013-02-21T18:03:53+00:00

sorry about that nextChar method does not exist
do it like you were doing earlier:

char choice = (char)scan.nextLine().charAt(0);

uknown2 -4 Junior Poster in Training · Answer 4 · 2013-02-21T18:13:34+00:00

How come the variables are not in use..

Also the word choice does it have to have a capitcal C through out?

MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: Choice: A
Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - variable choice might not have been initialized
    at hotelprogram.Hotelprogram.main(Hotelprogram.java:34)
Java Result: 1
BUILD SUCCESSFUL (total time: 6 seconds)

DarkLightning7 12 Junior Poster in Training · Answer 5 · 2013-02-21T18:18:11+00:00

variables are cases sensitive meaning they have to match exactly for java to think they are the same thing.

Standard is to make variables camelCase first word lowercase and all following words uppercase

example: thisIsCamelCase

uknown2 -4 Junior Poster in Training · Answer 6 · 2013-02-21T18:22:41+00:00

I have fixed that one but most of my code is all red underlined.. :(

MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: Choice: A
Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - Erroneous sym type: addGuest
    at hotelprogram.Hotelprogram.main(Hotelprogram.java:42)
Java Result: 1

DarkLightning7 12 Junior Poster in Training · Answer 7 · 2013-02-21T18:26:07+00:00

well for starters whats on line 42?

also check what netbeans tells you by hovering your mouse over the caution symbols on the left of your code.

uknown2 -4 Junior Poster in Training · Answer 8 · 2013-02-21T18:32:05+00:00

**line 42 has addGuest();
**

  char Choice = (char)scan.nextLine().charAt(0);                        
                        if(Choice=='E')          //if the selection is E exit the loop

                              break;

                                  switch(Choice)
                                          {

                                      case 'A':
                                addGuest();
                                break;
                               case 'V':
                               viewRooms();
                                break;
                               default:
                                   break;
                                  }}}}

                              public void addGuest(){
                        //Add Guest
                        scan.nextLine();
                        System.out.print("Please enter your guest: ");
                        String guest=scan.nextLine();
                        names=addName(guest,names);
                        System.out.print("Room: ");
                        int room=scan.nextInt();
                        rooms=addRoom(room,rooms);
                        //sort rooms by ascending... don't use arrays.sort!
                        for(int x=0;x<rooms.length;x++)
                        {
                            for(int y=0;y<rooms.length;y++)
                            {
                                if(rooms[x]<rooms[y])
                                {
                                    int dummy=rooms[x];
                                    String dummy2=names[x];
                                    rooms[x]=rooms[y];
                                    names[x]=names[y];
                                    rooms[y]=dummy;
                                    names[y]=dummy2;
}}}




                     public void viewRooms(){
                    {
                        //List All Guests and Room Numbers
                        System.out.println("ROOM\t\t\tGUEST");
                        for(int x=0;x<rooms.length;x++)
                        {
                            System.out.println(rooms[x]+"\t\t\t"+ names[x]);
                        }

                                        }}

    public static String[] addName(String guest, String names[])
    {
        String x[]=new String[(names.length)+1];
        System.arraycopy(names,0,x,0,names.length);//System.arraycopy(first array, starting point, second array, start point, how much
        //add something for maybe if the person is already here, but cased differently??
        for(int a=0;a<x.length;a++)
        {
            if(guest.equalsIgnoreCase(x[a]))
            {
                System.out.println("This guest has already checked in.");
                System.out.print("New Guest: ");
                guest=scan.nextLine();
            }
        }
        x[x.length-1]=guest;
        return x;   
    }

    public static int[] addRoom(int room, int rooms[])
    {
        int r[]=new int[(rooms.length)+1];
        System.arraycopy(rooms,0,r,0,rooms.length);//System.arraycopy(first array, starting point, second array, start point, how much
        for(int x=0;x<r.length;x++)
        {
            if(r[x]==room)
            {
                System.out.println("ROOM ALREADY OCCUPIED!");
                System.out.print("Reenter room: ");
                room=scan.nextInt();
            }
        }
        r[r.length-1]=room;
        return r;
}

DarkLightning7 12 Junior Poster in Training · Answer 9 · 2013-02-21T19:04:03+00:00

i corrected all the problems i could find the program now works for the first two choices. the problems are listed in the comments the first time they show all proceeding instances are uncommented.

This is a great little program i hope you continue to improve your skills.

A couple things you should do before working on this any more:
1. read about scope in java
2. read about static vs non static

package tests;

import java.util.Scanner;

public class Test {
    static String names[]=new String[0]; 
    static int rooms[]=new int[0];      //had to move these outside of main to make them accessable to your methods.

    public static void main(String[] args){
        Scanner scan = new Scanner(System.in);

        do{
            char choice;
            System.out.println("\n\nMENU ");//menu
            System.out.println("A) Add Guest");
            System.out.println("V) View All Rooms");
            System.out.println("D) Display Empty Rooms");
            System.out.println("F) Find Room From Customer Name");
            System.out.println("S) Store Program data into file");
            System.out.println("L) Load Program from data file");
            System.out.println("R) View Rooms Alphabetically");
            System.out.println("E) Exit program");
            System.out.print("Choice: ");

            char Choice = (char)scan.nextLine().charAt(0);

            if(Choice=='E')
                break;

            switch(Choice){
                case 'A':
                    addGuest();  //you were calling a non static method from main here.  that not allowed
                    break;
                case 'V':
                    viewRooms();
                    break;
                default:
                    break;
             }

        }while(true);
    }

    public static void addGuest(){  //if you dont put methodds in a seperate class and instance an object they have to be static to use inside of main.
        Scanner scan = new Scanner(System.in);  //variable scope is importaint since the previous scanner is in main you need to create a new one inside of all of your methods that are outside of main.
        scan.nextLine();

        System.out.print("Please enter your guest: ");
        String guest=scan.nextLine();

        names=addName(guest,names);
        System.out.print("Room: ");

        int room=scan.nextInt();
        rooms=addRoom(room,rooms);
        //sort rooms by ascending... don't use arrays.sort!

        for(int x=0;x<rooms.length;x++){
            for(int y=0;y<rooms.length;y++){
                if(rooms[x]<rooms[y]){
                    int dummy=rooms[x];
                    String dummy2=names[x];
                    rooms[x]=rooms[y];
                    names[x]=names[y];
                    rooms[y]=dummy;
                    names[y]=dummy2;
                }
            }
        }
    }

    public static void viewRooms(){
        System.out.println("ROOM\t\t\tGUEST");
        for(int x=0;x<rooms.length;x++){
            System.out.println(rooms[x]+"\t\t\t"+ names[x]);
        }
    }

    public static String[] addName(String guest, String names[]){
        Scanner scan = new Scanner(System.in);
        String x[]=new String[(names.length)+1];
        System.arraycopy(names,0,x,0,names.length);

        for(int a=0;a<x.length;a++){
            if(guest.equalsIgnoreCase(x[a])){
                System.out.println("This guest has already checked in.");
                System.out.print("New Guest: ");
                guest=scan.nextLine();
            }
        }

        x[x.length-1]=guest;
        return x;   
    }

    public static int[] addRoom(int room, int rooms[]){
        Scanner scan = new Scanner(System.in);
        int r[]=new int[(rooms.length)+1];
        System.arraycopy(rooms,0,r,0,rooms.length);

        for(int x=0;x<r.length;x++){
            if(r[x]==room){
                System.out.println("ROOM ALREADY OCCUPIED!");
                System.out.print("Reenter room: ");
                room=scan.nextInt();
            }
        }

        r[r.length-1]=room;
        return r;
    }
}

uknown2 -4 Junior Poster in Training · Answer 10 · 2013-02-21T19:33:23+00:00

i will start reading in to what u have suggested asap..

for now i still have a error.. when i take static out the error goes but doesnt run.

Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - non-static variable names cannot be referenced from a static context
    at hotelprogram.Hotelprogram.addGuest(Hotelprogram.java:64)
    at hotelprogram.Hotelprogram.main(Hotelprogram.java:44)
Java Result: 1






                              public static void addGuest(){

                              Scanner scan = new Scanner(System.in);
                        //Add Guest
                        scan.nextLine();

      System.out.print("Please enter your guest: ");
        String guest=scan.nextLine();
        names=addName(guest,names);
        System.out.print("Room: ");
        int room=scan.nextInt();
        rooms=addRoom(room,rooms);
        //sort rooms by ascending... don't use arrays.sort!
        for(int x=0;x<rooms.length;x++){
            for(int y=0;y<rooms.length;y++){
                if(rooms[x]<rooms[y]){
                    int dummy=rooms[x];
                    String dummy2=names[x];
                    rooms[x]=rooms[y];
                    names[x]=names[y];
                    rooms[y]=dummy;
                    names[y]=dummy2;
                }
            }
        }
    }

uknown2 -4 Junior Poster in Training · Answer 11 · 2013-02-21T19:53:28+00:00

uknown2 -4 Junior Poster in Training

11 Years Ago

yea i did.. ill go throught it proper

Edited 11 Years Ago by uknown2 because: wrong post

uknown2 -4 Junior Poster in Training · Answer 12 · 2013-02-21T20:01:21+00:00

I have got it working thank you..

I just need to work on the other methods. :)

I really appreciate the time u have take out to reply and helped me.

Thank You very much..

I may need some help with the methods like reading from file, storing data in file etc.. but ill work on it and then if i need help ill let u.

Thank you once again

uknown2 -4 Junior Poster in Training · Answer 13 · 2013-02-21T21:41:04+00:00

I am trying to do the look up guest method but i have a slight problem..

if the guest hasnt checked in it gives ERROR..

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -1
    at hotel_program.Main.lookupCustomer(Main.java:91)
    at hotel_program.Main.main(Main.java:43)
Java Result: 1

LINE 91 IS

    System.out.println(names[search]+" has not checked into this hotel");

LINE 43 IS

 lookupCustomer();

it finds the customer to begin.
it works but it just doesnt do what its meants to..

please cn you tell me where i have gone wrong?

public static void lookupCustomer(){            
//Search for a cstomer
             Scanner scan = new Scanner(System.in);
scan.nextLine();
int search=-1;
System.out.print("Enter the name of the guest that is being searched: ");** //I CHANGED THIS SEMI-CLN TO A COLLON IT THEN ALLOWS THE DIFFERNT CUSTOMER SEARCH TO HAPPEN SHOWING DIFFERNT CUSTMERS RATHER THAN THE SAME NAME AGAIN AND AGAIN**
String searchName=scan.nextLine();
for(int x=0;x<names.length;x++)
{   
if(names[x].equalsIgnoreCase(searchName));
{//Every time I search for a guest it says the guest of the first cell is here will explain with output
    search=x;
    break;
}   }                   
if(search==-1)
System.out.println(names[search]+" has not checked into this hotel");
else
   System.out.println(names[search]+" is checked into room "+rooms[search]);

                    }

DarkLightning7 12 Junior Poster in Training · Answer 14 · 2013-02-21T23:02:11+00:00

The array index out of bounds error means that your trying to access part of the array that does not exist. so your index is either bigger than the last element in the array (array.length-1) or less than 0. see if you can find where your index is becomming larger than the number of values in the array.

uknown2 -4 Junior Poster in Training · Answer 15 · 2013-02-22T01:58:20+00:00

I have been trying to research it but i cant seem to fix the error just keep coming up with more errors. :(
Do u know of any site that may help me understand??

DarkLightning7 12 Junior Poster in Training · Answer 16 · 2013-02-22T02:20:24+00:00

if you notice in your previous post your allowing search to become negative then using it as an array index. Array indexes can't be negative. They start at 0 and go till the end of the array.

uknown2 -4 Junior Poster in Training · Answer 17 · 2013-02-22T02:31:33+00:00

I have changed it but now the if else statment is not working accordingly. The search is not working properly..
the results are as follows.

MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: A

Please enter your guest: ALEX
Room: 1


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: A

Please enter your guest: RYAN
Room: 
2


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: V
ROOM            GUEST
1           ALEX
2           RYAN


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: F

Enter the name of the guest that is being searched: RYAN
ALEX is checked into room 1


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: F

Enter the name of the guest that is being searched: ALEX
ALEX is checked into room 1


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: E
BUILD SUCCESSFUL (total time: 51 seconds)

DarkLightning7 12 Junior Poster in Training · Answer 18 · 2013-02-22T19:27:05+00:00

here are two problems i noticed with your last code post. If they dont fix your problem go ahead and post your code again so i can look for the problem.

public static void lookupCustomer(){            
    Scanner scan = new Scanner(System.in);
    scan.nextLine();
    int search=-1;

    System.out.print("Enter the name of the guest that is being searched: ");
    String searchName=scan.nextLine();

    for(int x=0;x<names.length;x++){  //just a comment not shure if you know this or not its fine here.  If names last index is 19 names.length will return 20.  be careful.   
        if(names[x].equalsIgnoreCase(searchName));{  // there should not be a semi colin here this is your search problem.
            search=x;
            break;
        }
    }

    if(search==-1)  //checking if search == -1 is fine as long as you dont use it as an array index if it is -1
    System.out.println(names[search]+" has not checked into this hotel"); //this line names[search] should be replaced by searchName
    else
        System.out.println(names[search]+" is checked into room "+rooms[search]);
}

uknown2 -4 Junior Poster in Training · Answer 19 · 2013-02-23T21:49:50+00:00

Hey sorry about the late reply...

I am still having an error.. the error is within these lines. i tried to change the code around but not successfull.

    if (search==-1)  //checking if search == -1 is fine as long as you dont use it as an array index if it is -1
    System.out.println(names[searchName]+" has not checked into this hotel"); //this line names[search] should be replaced by searchName
    else{
        System.out.println(names[searchName]+" is checked into room "+rooms[search]);
}}

Exception in thread "main" java.lang.RuntimeException: Uncompilable source code - incompatible types
required: int

zeroliken 79 Nearly a Posting Virtuoso · Answer 20 · 2013-02-24T01:06:07+00:00

*judging from recent posts

your array expects an integer and searchName is a String

uknown2 -4 Junior Poster in Training · Answer 21 · 2013-02-27T03:24:11+00:00

i have tried to change it but it still says error :(

uknown2 -4 Junior Poster in Training · Answer 22 · 2013-02-27T04:09:18+00:00

pLEASE CAN SOME ONE HELP ME FIX THIS CODE.. I JUST DONT UNDERSTAND WHY ITS NOT LOOKING UP THE CUSTOMER WITH THE CORRECT NAME BEING SEARCHED..
THE OUT PUT FOR THIS CODE IS .....

MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: A

Please enter your guest: TOM
Room: 4


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: A

Please enter your guest: PHIL
Room: 3


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: V
ROOM            GUEST
3           PHIL
4           TOM


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: F

Enter the name of the guest that is being searched: TOM
PHIL has not checked into this hotel


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: F

Enter the name of the guest that is being searched: PHIL
PHIL has not checked into this hotel







 public static void lookupCustomer(){            
    Scanner scan = new Scanner(System.in);
    scan.nextLine();
    int search=0;
    System.out.print("Enter the name of the guest that is being searched: ");
    String searchName=scan.nextLine();
    for(int x=0;x<names.length;x++){  //just a comment not shure if you know this or not its fine here.  If names last index is 19 names.length will return 20.  be careful.   
        if(names[x].equalsIgnoreCase(searchName));{  // there should not be a semi colin here this is your search problem.
            search=x;
            break;

uknown2 -4 Junior Poster in Training · Answer 23 · 2013-02-27T15:07:19+00:00

please can any one help me. how would i change the code to get a string and not a int???

uknown2 -4 Junior Poster in Training · Answer 24 · 2013-02-27T18:47:43+00:00

uknown2 -4 Junior Poster in Training

11 Years Ago

anyone help m???

stultuske 1,116 Posting Maven Featured Poster · Answer 25 · 2013-02-27T19:03:45+00:00

stultuske 1,116 Posting Maven

11 Years Ago

ehm ....

int a = 1;
return a+"";

uknown2 -4 Junior Poster in Training · Answer 26 · 2013-02-27T19:07:11+00:00

erm but with my code it wants a interger but i need to change it to an string..

how would i do that

public static void lookupCustomer(){            
    Scanner scan = new Scanner(System.in);
    scan.nextLine();
    int search=0;
    System.out.print("Enter the name of the guest that is being searched: ");
    String searchName=scan.nextLine();
    for(int x=0;x<names.length;x++){   
        if(names[x].equalsIgnoreCase(searchName));{  
            search=x;
            break;

DarkLightning7 12 Junior Poster in Training · Answer 27 · 2013-02-27T19:33:59+00:00

your code looks fine to me please post the stack trace and describe the problem. Thanks.

uknown2 -4 Junior Poster in Training · Answer 28 · 2013-02-27T19:38:02+00:00

THERE IS NO ERROR WITH THE CODE!! BUT THE OUT COMES OUT WRONG..

BELOW I HAVE ADDED 2 CUSTOMERS AND THEN PRESSED "F" TO FIND THE CUSTOMER BUT THE OUTPUT IS WRONG...
IF U LOOK AT THE LAST THRE MENU OUTPUTS U WILL SEE WHAT IM SAYING

MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: A

Please enter your guest: TOM
Room: 2




    MENU 
    A) Add Guest
    V) View All Rooms
    D) Display Empty Rooms
    F) Find Room From Customer Name
    S) Store Program data into file
    L) Load Program from data file
    R) View Rooms Alphabetically
    E) Exit program
    Choice: A

    Please enter your guest: LISA
    Room: 2
    ROOM ALREADY OCCUPIED!
    Reenter room: 4


    MENU 
    A) Add Guest
    V) View All Rooms
    D) Display Empty Rooms
    F) Find Room From Customer Name
    S) Store Program data into file
    L) Load Program from data file
    R) View Rooms Alphabetically
    E) Exit program
    Choice: F

    Enter the name of the guest that is being searched: LISA
    TOM is checked into room 2


    MENU 
    A) Add Guest
    V) View All Rooms
    D) Display Empty Rooms
    F) Find Room From Customer Name
    S) Store Program data into file
    L) Load Program from data file
    R) View Rooms Alphabetically
    E) Exit program
    Choice: F

    Enter the name of the guest that is being searched: TOM
    TOM is checked into room 2


MENU 
A) Add Guest
V) View All Rooms
D) Display Empty Rooms
F) Find Room From Customer Name
S) Store Program data into file
L) Load Program from data file
R) View Rooms Alphabetically
E) Exit program
Choice: F

Enter the name of the guest that is being searched: PHIL
TOM is checked into room 2

uknown2 -4 Junior Poster in Training · Answer 29 · 2013-02-27T22:20:40+00:00

uknown2 -4 Junior Poster in Training

11 Years Ago

i guess no1 can help :( thnks nyway