How to get size of all files in a directory

Nice code, can be used for something, surely :)

Sweet, but there's an unused std::string declared in the main.

OK, I'm being a nitpick. :)

This code is wrong.
See MSDN official sample (reparse points, etc...)

>>This code is wrong.
There are as many ways to do something as there are programmers to do it. What exactly is wrong with the code I posted? Post a link to the article you site.

BTW there is no such thing as an "MSDN Official sample". They just provide samples, there is nothing "official" about them.

[edit] reparse points have nothing at all to do with the topic of this thread. So it becomes obvious you don't have the slightest clue what you are talking about.

MSDN isn't perfect all the time. I've corrected a bunch of erroneous "official samples", and there are some terribly gross code examples on MSDN. There are topics that are incorrectly documented about, and so on. Do you know that there's website called "connect" where you could get on and report these errors?

I do agree with Ancient Dragon - there are many ways to do the same thing, so just get over your pointless criticism.

Rajesh
Microsoft MVP, Visual C++

I wouldn't go that far to declare this code wrong. However, such simplistic approach is inherently dangerous. See for example this article. For more details, also look at this.

Although that would rarly exist, here is how to avoid such directories. This also will not parse hidden directories, such as the recycle bin.

__int64 TransverseDirectory(string path)
{
    WIN32_FIND_DATA data;
    __int64 size = 0;
    string fname = path + "\\*.*";
    HANDLE h = FindFirstFile(fname.c_str(),&data);
    if(h != INVALID_HANDLE_VALUE)
    {
        cout << path << '\n';
        do {
            if( (data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) )
            {
                if( !(data.dwFileAttributes & FILE_ATTRIBUTE_HIDDEN) 
                    && !(data.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT))
                {
                    // make sure we skip "." and "..".  Have to use strcmp here because
                    // some file names can start with a dot, so just testing for the 
                    // first dot is not suffient.
                    if( strcmp(data.cFileName,".") != 0 &&strcmp(data.cFileName,"..") != 0)
                    {
                        // We found a sub-directory, so get the files in it too
                        fname = path + "\\" + data.cFileName;
                        // recurrsion here!
                        size += TransverseDirectory(fname);
                    }
                }

            }
            else
            {
                LARGE_INTEGER sz;
                // All we want here is the file size.  Since file sizes can be larger
                // than 2 gig, the size is reported as two DWORD objects.  Below we
                // combine them to make one 64-bit integer.
                sz.LowPart = data.nFileSizeLow;
                sz.HighPart = data.nFileSizeHigh;
                size += sz.QuadPart;

            }
        }while( FindNextFile(h,&data) != 0);
        FindClose(h);

    }
    return size;
}