using pointers in C++ for array

[number87]

ok so what im trying to do is to read some text from a file. Put them into an array. And count the number of characters in the text file using pointers to access the array. However, when i compile i get an error for this line check = isalpha('*text'); It says the character constant is too long for its type. Im kinda stuck at this point and not sure how to solve it.

const int SIZE = 500;
char fileName[20];
char text[SIZE];

int main()
{                  
    cout << "Enter filename: " << endl;
    cin >> fileName;  
                     
    fstream infile(fileName, ios::in);
    infile.getline(text, SIZE);

    int charNum = countChar(text);
    cout << "Number of characters: " << charNum << endl;
    
infile.close();
return 0;
}

int countChar(char* text)
{      
    int count1 = 0;
    bool check;
    
    while (*text != '\0')
    {         
      check = isalpha('*text');
      if(check == true)
      count1++;
      text++;
           
    }   
    
    return count1;
          
}

[iamthwee]

It would be, isalpha expects one character.

[number87]

so correct me if im wrong...i read the text file, then put the characters into an array, and im pretty sure *text in check = isalpha('*text'); refers to a single array element....

ahhh....still cant figure out whats wrong

[mrboolf]

Try to remove the ' ' around *text

[number87]

ok i tried that and......it created another error....

[mrboolf]

and the error is... ?

[number87]

and the error is... ?

invalid conversion from `char**' to `int'

[mrboolf]

I think there could be a typing error somewhere in your code. I tried this

#include <iostream>
#include <fstream>

using namespace std;

const int SIZE = 500;
char fileName[20];
char text[SIZE];

int countChar(char* text);

int main() {                  
    cout << "Enter filename: " << endl;
    cin >> fileName;        
    fstream infile(fileName, ios::in);
    infile.getline(text, SIZE);
    int charNum = countChar(text);
    cout << "Number of characters: " << charNum << endl;
	infile.close();
	return 0;
}

int countChar(char* text) {      
    int count1 = 0;
    bool check;
    while (*text != '\0') {         
      check = isalpha(*text);
      if(check == true)
      	count1++;
      text++;      
    }   
    return count1; 
}

which to me looks like your code and it works fine. I didn't change anything other than indentation and #includes and countChar prototype added...

[number87]

this is very weird LOL
i deleted the #include <cstring> and the ' ' around *text

IT WORKED! soooo weird