Member Avatar for xairzx

hi all
im creating a simple timer.it have NumericUpDown and Progress Bar.
i use NumericUpDown to set the timer in minutes.I also put Progress Bar to indicates the percentage of times completed.For example if i set the timer to 1 minutes so if it at 0.5 minutes the Progress Bar will show 50% completed.But the problem here is the Progress Bar is not working.

here is the coding

Public Class Form1
    Inherits System.Windows.Forms.Form

 Private Sub Timer1_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer1.Tick


        If ProgressBar1.Value < ProgressBar1.Maximum Then
            ProgressBar1.Value += 2
        Else
            ProgressBar1.Value = ProgressBar1.Minimum
        End If

        lblmsg.Text = "Percentage Complete : " & ProgressBar1.Value & "%"
        Timer1.Enabled = False

    End Sub


    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Dim Minutes As Integer = NumericUpDown1.Value
        Timer1.Interval = Minutes * 60 * 1000
        Timer1.Enabled = True
        MsgBox("The timer has been set.", MsgBoxStyle.Information And MsgBoxStyle.OKOnly, "Timer Set")

    End Sub

    Private Sub NumericUpDown1_ValueChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles NumericUpDown1.ValueChanged

    End Sub

    Private Sub ProgressBar1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles ProgressBar1.Click

    End Sub
End Class

any thought?

Edited by xairzx because: n/a
  • 2 Contributors
  • 1 Reply
  • 1K Views
  • 8 Hours Discussion Span
  • Latest Post Latest Post by Oxiegen

Dani AI

Generated

the main issue is timing, not the ProgressBar. You set Timer1.Interval to the full duration (minutes 60 1000) and then turn the timer off inside Tick. That guarantees only one tick per run, so the bar never advances gradually. Keep the timer ticking at a small, steady interval and compute percent from actual elapsed time. That way the bar reaches exactly 100% at the requested minute mark.

Here is a simple, time-based pattern that avoids rounding errors and hard-coded increments:

' Form-level fields
Private _start As DateTime
Private _duration As TimeSpan

Private Sub Button1_Click(...) Handles Button1.Click
    Dim minutes As Integer = CInt(NumericUpDown1.Value)
    If minutes <= 0 Then minutes = 1 ' guard
    _start = DateTime.Now
    _duration = TimeSpan.FromMinutes(minutes)

    ProgressBar1.Minimum = 0
    ProgressBar1.Maximum = 100
    ProgressBar1.Value = 0

    Timer1.Interval = 100   ' 10 updates per second
    Timer1.Start()
End Sub

Private Sub Timer1_Tick(...) Handles Timer1.Tick
    Dim elapsed = DateTime.Now - _start
    Dim pct As Integer = CInt(Math.Floor(100.0 * elapsed.TotalMilliseconds / _duration.TotalMilliseconds))
    pct = Math.Max(0, Math.Min(100, pct))

    If ProgressBar1.Value <> pct Then ProgressBar1.Value = pct
    lblmsg.Text = "Percentage Complete : " & pct & "%"

    If elapsed >= _duration Then
        Timer1.Stop()
    End If
End Sub

If you prefer the increment approach suggested, make the math line up with your duration: choose a small Interval and set ProgressBar1.Maximum to the number of ticks in the run. For example, with Interval = 500 ms, Maximum = minutes * 60 * 1000 / 500. Then increment by 1 each tick and stop at Maximum. Either pattern keeps the UI responsive and the percentage accurate.

Member Avatar for Oxiegen

I would do this instead in the Timer_Tick event:

Private Sub Timer1_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer1.Tick


        If ProgressBar1.Value >= ProgressBar1.Maximum Then
            ProgressBar1.Value = ProgressBar1.Minimum
            Timer1.Enabled = False
        Else
            ProgressBar1.Increment(2)    '' Notice the difference?
            If ProgressBar1.Value >= ProgressBar1.Maximum Then
                        ProgressBar1.Value = ProgressBar1.Maximum
                        Timer1.Enabled = False
            End If
            lblmsg.Text = "Percentage Complete : " & ProgressBar1.Value & "%"
        End If
    End Sub

Redundacy is sometimes a good thing.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.