Progress bar when execute method

Question

manhthaodn 0 Light Poster

14 Years Ago

Hi,

I have load data method as follows:

    public List<SalesOrderHeader> Load_SaleOrderRelatedInfo()
            {
                try
                {
                    using (var context = new AdventureWorksEntities())
                    {
                        return context.SalesOrderHeaders.Include("SalesOrderDetails").OrderBy(so => so.SalesOrderNumber).ToList();
                    }
                }
                catch (Exception ex)
                {
                    throw ex;
                }
            }

and method for data binding:

public static DataTable Binding_SaleOrderInfoRelated()
        {
            using (var services = new ServiceTransferClient())
            {
                var table = new DataTable();
                SalesOrderHeader[] orders = services.Load_SaleOrderRelatedInfo();


            table.Columns.Add("SalesOrderID", typeof(int));
            table.Columns.Add("RevisionNumber", typeof(int));
            table.Columns.Add("OrderDate", typeof(DateTime));
            table.Columns.Add("DueDate", typeof(DateTime));
            table.Columns.Add("ShipDate", typeof(DateTime));
            table.Columns.Add("Status", typeof(int));
            table.Columns.Add("OnlineOrderFlag", typeof(int));
            table.Columns.Add("SalesOrderNumber", typeof(string));
            table.Columns.Add("PurchaseOrderNumber", typeof(string));
            table.Columns.Add("AccountNumber", typeof(string));
            table.Columns.Add("CustomerID", typeof(int));
            table.Columns.Add("ContactID", typeof(int));
            table.Columns.Add("SalesPersonID", typeof(int));
            table.Columns.Add("TerritoryID", typeof(int));
            table.Columns.Add("BillToAddressID", typeof(int));
            table.Columns.Add("ShipToAddressID", typeof(int));
            table.Columns.Add("ShipMethodID", typeof(int));
            table.Columns.Add("CreditCardID", typeof(int));
            table.Columns.Add("CreditCardApprovalCode", typeof(string));
            table.Columns.Add("CurrencyRateID", typeof(int));
            table.Columns.Add("SubTotal", typeof(decimal));
            table.Columns.Add("TaxAmt", typeof(decimal));
            table.Columns.Add("Freight", typeof(decimal));
            table.Columns.Add("TotalDue", typeof(decimal));
            table.Columns.Add("Comment", typeof(string));

            table.Columns.Add("SalesOrderDetailID", typeof(int));
            table.Columns.Add("CarrierTrackingNumber", typeof(string));
            table.Columns.Add("OrderQty", typeof(int));
            table.Columns.Add("ProductID", typeof(int));
            table.Columns.Add("SpecialOfferID", typeof(int));
            table.Columns.Add("UnitPrice", typeof(decimal));
            table.Columns.Add("UnitPriceDiscount", typeof(decimal));
            table.Columns.Add("LineTotal", typeof(double));

            foreach (var o in orders)
            {
                var rows = table.NewRow();

                rows["SalesOrderID"] = o.SalesOrderID;
                rows["RevisionNumber"] = o.RevisionNumber;
                rows["OrderDate"] = o.OrderDate;
                rows["DueDate"] = o.DueDate;
                rows["ShipDate"] = o.ShipDate;
                rows["Status"] = o.Status;
                rows["OnlineOrderFlag"] = o.OnlineOrderFlag;
                rows["SalesOrderNumber"] = o.SalesOrderNumber;
                rows["PurchaseOrderNumber"] = o.PurchaseOrderNumber;
                rows["AccountNumber"] = o.AccountNumber;
                rows["CustomerID"] = o.CustomerID;
                rows["ContactID"] = o.ContactID;
                rows["SalesPersonID"] = o.SalesPersonID.GetValueOrDefault();
                rows["TerritoryID"] = o.TerritoryID;
                rows["BillToAddressID"] = o.BillToAddressID;
                rows["ShipToAddressID"] = o.ShipToAddressID;
                rows["ShipMethodID"] = o.ShipMethodID;
                rows["CreditCardID"] = o.CreditCardID.GetValueOrDefault();
                rows["CreditCardApprovalCode"] = o.CreditCardApprovalCode;
                rows["CurrencyRateID"] = o.CurrencyRateID.GetValueOrDefault();
                rows["SubTotal"] = o.SubTotal;
                rows["TaxAmt"] = o.TaxAmt;
                rows["Freight"] = o.Freight;
                rows["TotalDue"] = o.TotalDue;
                rows["Comment"] = o.Comment;

                table.Rows.Add(rows);

                foreach (var od in o.SalesOrderDetails)
                {
                    var rows1 = table.NewRow();
                    rows1["SalesOrderID"] = o.SalesOrderID;
                    rows1["SalesOrderDetailID"] = od.SalesOrderDetailID;
                    rows1["CarrierTrackingNumber"] = od.CarrierTrackingNumber;
                    rows1["OrderQty"] = od.OrderQty;
                    rows1["ProductID"] = od.ProductID;
                    rows1["SpecialOfferID"] = od.SpecialOfferID;
                    rows1["UnitPrice"] = od.UnitPrice;
                    rows1["UnitPriceDiscount"] = od.UnitPriceDiscount;
                    rows1["LineTotal"] = od.LineTotal;

                    table.Rows.Add(rows1);
                }
            }

            return table;
        }
    }

because the amount of data so large that when executed method take times. To reduce the waiting and anxious, can use the progress bar, progress bar is finished when the data is loaded.

How can I do?

THANKS!

.net:c#

3 Contributors
8 Replies
617 Views
4 Days Discussion Span
Latest Post 14 Years Ago Latest Post by Mike Askew

Dani AI

Generated 10 Months Ago

Summary and quick diagnosis: the progress bar shown in the replies (thanks to ) will only update if the UI thread is free to process paint messages — as noted, long synchronous work on the UI thread makes the form freeze so the bar appears stuck. Two robust options: perform the heavy work off the UI thread and report progress back, or avoid loading everything at once (paging / virtual mode).

A simple, modern pattern (Task + Progress<T>) — build the DataTable on a background thread, report incremental progress, then bind the finished table on the UI thread. The UI must not be touched from the background thread (create/close the service client on the background thread too). Example pattern:

private async Task<DataTable> LoadTableAsync(IProgress<int> progress)
{
    return await Task.Run(() =>
    {
        var table = new DataTable();
        using (var svc = new ServiceTransferClient())
        {
            var orders = /* call service to retrieve orders list */;
            int i = 0;
            foreach (var o in orders)
            {
                // build rows into 'table' (no UI calls here)
                i++;
                progress.Report(i);
            }
            // svc.Close/Dispose handled by using
        }
        return table;
    });
}

private async void btnLoad_Click(object sender, EventArgs e)
{
    progressBar.Visible = true;
    var progress = new Progress<int>(v => progressBar.Value = v);
    var table = await LoadTableAsync(progress);
    dataGridView.DataSource = table;
    progressBar.Visible = false;
}

Notes and cautions:

Set progressBar.Maximum on the UI thread once the total work count is known; if getting the count is expensive, show an indeterminate bar (ProgressBarStyle.Marquee) until the count is available.
Never update UI controls from the background thread; use Progress<T>, Control.Invoke, or BackgroundWorker.ReportProgress.
For very large datasets prefer server-side paging or DataGridView.VirtualMode + CellValueNeeded so only currently visible rows are materialized. That will be far faster and use much less memory than loading everything and trying to animate a progress bar for it.

All 8 Replies

samsylvestertty 12 Newbie Poster

14 Years Ago

Set visibility = true before the function Binding_SaleOrderInfoRelated
Set thr progress bar's max property to orders.Count

increment the progress bar's value property by 1 at the end of each iteration

foreach (var o in orders)
{
    .
    .
    .
    progressBar.Value++;
}

Set visibility = false after the function Binding_SaleOrderInfoRelated

Hope it works

Mike Askew 131 Veteran Poster

14 Years Ago

It is worth noting if you are not running a multi-threaded application the load bar will not update normally as the form will 'freeze' until the whole thread has run, ie. bar will jump from 0% to 100%.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

manhthaodn 0 Light Poster · Answer 1 · 2012-08-10T12:08:44+00:00

Hi samsylvestertty

I do not know how to do? you can specify more clearly. Give me a sample code?

Thanks!

manhthaodn 0 Light Poster · Answer 2 · 2012-08-10T12:32:08+00:00

Hi MikeyIsMe,

Can you give me a sample to do that in my case to understand more?

Thanks

samsylvestertty 12 Newbie Poster · Answer 3 · 2012-08-11T08:34:33+00:00

public static DataTable Binding_SaleOrderInfoRelated()
        {
            using (var services = new ServiceTransferClient())
            {
                var table = new DataTable();
                SalesOrderHeader[] orders = services.Load_SaleOrderRelatedInfo();


            table.Columns.Add("SalesOrderID", typeof(int));
            table.Columns.Add("RevisionNumber", typeof(int));
            table.Columns.Add("OrderDate", typeof(DateTime));
            table.Columns.Add("DueDate", typeof(DateTime));
            table.Columns.Add("ShipDate", typeof(DateTime));
            table.Columns.Add("Status", typeof(int));
            table.Columns.Add("OnlineOrderFlag", typeof(int));
            table.Columns.Add("SalesOrderNumber", typeof(string));
            table.Columns.Add("PurchaseOrderNumber", typeof(string));
            table.Columns.Add("AccountNumber", typeof(string));
            table.Columns.Add("CustomerID", typeof(int));
            table.Columns.Add("ContactID", typeof(int));
            table.Columns.Add("SalesPersonID", typeof(int));
            table.Columns.Add("TerritoryID", typeof(int));
            table.Columns.Add("BillToAddressID", typeof(int));
            table.Columns.Add("ShipToAddressID", typeof(int));
            table.Columns.Add("ShipMethodID", typeof(int));
            table.Columns.Add("CreditCardID", typeof(int));
            table.Columns.Add("CreditCardApprovalCode", typeof(string));
            table.Columns.Add("CurrencyRateID", typeof(int));
            table.Columns.Add("SubTotal", typeof(decimal));
            table.Columns.Add("TaxAmt", typeof(decimal));
            table.Columns.Add("Freight", typeof(decimal));
            table.Columns.Add("TotalDue", typeof(decimal));
            table.Columns.Add("Comment", typeof(string));

            table.Columns.Add("SalesOrderDetailID", typeof(int));
            table.Columns.Add("CarrierTrackingNumber", typeof(string));
            table.Columns.Add("OrderQty", typeof(int));
            table.Columns.Add("ProductID", typeof(int));
            table.Columns.Add("SpecialOfferID", typeof(int));
            table.Columns.Add("UnitPrice", typeof(decimal));
            table.Columns.Add("UnitPriceDiscount", typeof(decimal));
            table.Columns.Add("LineTotal", typeof(double));
            //I assume you have a progress bar control named progressBar1
            //Set the progress bar's maximum attribute to the count
            progressBar1.Maximum = orders.Count; 
            //Show the progress bar
            progressBar1.Visible = true;
            foreach (var o in orders)
            {
                var rows = table.NewRow();

                rows["SalesOrderID"] = o.SalesOrderID;
                rows["RevisionNumber"] = o.RevisionNumber;
                rows["OrderDate"] = o.OrderDate;
                rows["DueDate"] = o.DueDate;
                rows["ShipDate"] = o.ShipDate;
                rows["Status"] = o.Status;
                rows["OnlineOrderFlag"] = o.OnlineOrderFlag;
                rows["SalesOrderNumber"] = o.SalesOrderNumber;
                rows["PurchaseOrderNumber"] = o.PurchaseOrderNumber;
                rows["AccountNumber"] = o.AccountNumber;
                rows["CustomerID"] = o.CustomerID;
                rows["ContactID"] = o.ContactID;
                rows["SalesPersonID"] = o.SalesPersonID.GetValueOrDefault();
                rows["TerritoryID"] = o.TerritoryID;
                rows["BillToAddressID"] = o.BillToAddressID;
                rows["ShipToAddressID"] = o.ShipToAddressID;
                rows["ShipMethodID"] = o.ShipMethodID;
                rows["CreditCardID"] = o.CreditCardID.GetValueOrDefault();
                rows["CreditCardApprovalCode"] = o.CreditCardApprovalCode;
                rows["CurrencyRateID"] = o.CurrencyRateID.GetValueOrDefault();
                rows["SubTotal"] = o.SubTotal;
                rows["TaxAmt"] = o.TaxAmt;
                rows["Freight"] = o.Freight;
                rows["TotalDue"] = o.TotalDue;
                rows["Comment"] = o.Comment;

                table.Rows.Add(rows);

                foreach (var od in o.SalesOrderDetails)
                {
                    var rows1 = table.NewRow();
                    rows1["SalesOrderID"] = o.SalesOrderID;
                    rows1["SalesOrderDetailID"] = od.SalesOrderDetailID;
                    rows1["CarrierTrackingNumber"] = od.CarrierTrackingNumber;
                    rows1["OrderQty"] = od.OrderQty;
                    rows1["ProductID"] = od.ProductID;
                    rows1["SpecialOfferID"] = od.SpecialOfferID;
                    rows1["UnitPrice"] = od.UnitPrice;
                    rows1["UnitPriceDiscount"] = od.UnitPriceDiscount;
                    rows1["LineTotal"] = od.LineTotal;

                    table.Rows.Add(rows1);
                }
                //Increment the progress bar value
                progressBar1.Value++;
            }
            //Hide the progress bar
            progressBar1.Visible = false;
            return table;
        }
    }

As MikeyIsMe said there might be a problem. I tried it at my side and I got the progress bar functioning properly (however the main screen freezes). You try the code and tell if any problem arises then we'll try for a seperate thread to run a progress bar.

manhthaodn 0 Light Poster · Answer 4 · 2012-08-14T07:44:08+00:00

Hi samsylvestertty,

I follow your instructions but the results are not as expected.

When my program is processing, the progress bar does not run the wait process.

Thanks!

manhthaodn 0 Light Poster · Answer 5 · 2012-08-14T07:47:05+00:00

I think it can also paging on datagrid view, instead of load all data (Program runs slower if the data is too large)

Mike Askew 131 Veteran Poster Featured Poster · Answer 6 · 2012-08-14T08:36:20+00:00

Datagrid paging: http://www.codeproject.com/Articles/16303/DataGrid-Paging-C-Windows-Forms

What exactly is the issue with the progress bar? Does it update? Or does it stay blank and update at the end? Please clarify

Progress bar when execute method

Dani AI

Recommended Answers Collapse Answers

All 8 Replies

Recommended Answers