Member Avatar for Atlanta15Braves

I am trying to switch the below code to sort in descending order rather than ascending. It works when counting upwards, but nothing I try helps with getting it to count starting with the largest number and count downward.

public static void insertionSort(Comparable[] list) {
        for (int index = 1; index < list.length; index++) {
            Comparable key = list[index];
            int position = index;

That is the ascending part which works, and the while loop follows.

while (position > 0 && key.compareTo(list[position - 1]) < 0) {
                list[position] = list[position - 1];
                position--;

            }
            list[position] = key;


        }

Couldn't I just change something in the while condition to change the direction it counts, I have tried for an hour and nothing has worked.

  • 2 Contributors
  • 1 Reply
  • 766 Views
  • 9 Hours Discussion Span
  • Latest Post Latest Post by ~s.o.s~

Dani AI

Generated

: the fix is just to invert the comparison that decides when to shift an element. As hinted, Comparable.compareTo returns a negative integer when the left-hand object is less than the right-hand object, zero when equal, and a positive integer when greater. For descending order you want larger items moved left, so test for a positive result instead of a negative one (or swap the operands).

A few concrete tips without repeating your whole routine:

  • Change the shift condition to check for > 0 rather than < 0 (or use the opposite operand order).
  • Use > 0 (not >= 0) if you want insertion sort to remain stable (equal elements keep their original order).
  • Do not compare compareTo to 1 or -1; always check > 0, < 0, or == 0 because implementations may return other positive/negative values.

Extra precautions: make sure every element actually implements Comparable and that its compareTo is consistent with equals; otherwise you will see ClassCastExceptions or incorrect ordering. If you prefer not to hand-roll the sort, the Java standard library can do reverse order for you (for arrays or lists) — but for learning insertion sort the sign flip is the minimal, correct change.

If the sort still behaves oddly, add a few print statements or step through with a debugger to inspect key and the compared neighbor at each iteration; that usually exposes either a wrong comparison direction or a broken compareTo implementation.

Member Avatar for ~s.o.s~

Think about which piece of code (or specifically which method call) in your above snippet is responsible for doing the comparisons. Read up on the Javadocs of the Comparable.compareTo method. Anything you see in there which can "reverse" the checks you are making?

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.