Help with 1.pointers and 2.error checking

[ReDeViL]

Hi guys

need a little help for my homework, any help is greatly appreciated.
:cheesy:

Qn 1. pointers
i have a problem with passing pointers to functions
code is as follows:

//function declaration
void computeProduct(product *pProduct,int *pBest); 

//function call
computeProduct(product *pProduct,int *pBest);

//function definition
void computeProduct(product *pProduct,int *pBest)
{
       //code
}

i keep gettin 2 errors when trying to compile:
a. expected primary expression before '*' token.
b. expected primary expression before "int".
both errors point to the function call.
any ideas/hints on what i'm doin wrong?
_________________________________________________________
Qn2. error checking
i need to error proof my program.
say i need to retrieve an integer input from user.
i need to make sure that the user inputs an integer or i will prompt him to re-enter value:

cout << "Enter integer value:";
cin >> test;
while (cin.fail())
{
     cin.clear();
     cin.ignore(1000,'n' );     
     cout << "Invalid entry, re-enter value:"
     cin >> test;
}

yet, i'm unable to find a simple way to error proof the above user's input if it is of float type.
i.e. if user enters 2.3, the variable test will automatically be allocated the value 2.
any ideas how to ensure i can detect if user enters a float value?

thanks for any help in advance.
:cheesy:

[Ancient Dragon]

>>//function call computeProduct(product *pProduct,int *pBest);

Do not include the data type in the function call, just the variable name, like this: computeProduct(pProduct, pBest); Q2: Error checking is a little more difficult to resolve; there is no simple way to do it. In your case I would get keyboard input as a string and then parse the string for illegal characters. Or get keyboard input one character at a time using get() function and test it for illegal characters.

[ReDeViL]

if i declare a pointer in the main function, pass it via a function as a parameter, point it to a variable that only exists in the called function, will i be able to retrieve the vlaue of the variable via the pointer in the mian function?

gretaly appreciate any help rendered.

[Ancient Dragon]

Not unless you pass a pointer to the pointer in main(). Something like this thread from yesterday.

Also you must make sure the object in the function will not go out of scope then the function returns to main(). Objects created on the stack do not exist beyond the lifetime of the function in which it was declared, so when the function returns to main the pointer will have an invalid address.

[ReDeViL]

given this simple example:

void changep(int*&p);

int main()
{
    int*p;
    int x;
    changep (p);
    
    cout << *p;
    x=*p;
    cout << x;
}

void changep(int*&p)
{
    int k=3;
    p=&k;
}

in the above case, i want the pointer p to point to a variable k of value 3 in the function. i then pass it back to main and display it.
but after assigning the value of p (which is already 3) to another variable x, the value of x becomes a weird value??
any idea what i'm doin wrong?
:?:

[~s.o.s~]

This is because you are assigning p the address of a variable k which is local to the function changep and hence k loses its existence (goes out of scope) as soon as the function exits.

[ReDeViL]

then y is it that when i display *p for the 1st time in the main AFTER the function was called, it still manages to display the value or 3?
it only displays rubbish after i try to change the value......

[Ancient Dragon]

If you make the variable k static then it will work because static variables are similar to globals except they only have scope within the function in which they are declared.

void changep(int*&p);

int main()
{
    int*p;
    int x;
    changep (p);
    
    cout << *p;
    x=*p;
    cout << x;
}

void changep(int*&p)
{
    static int k=3; // <<<<<< Here
    p=&k;
}

[ReDeViL]

wow, thanks!!
y didnt i think of that!
hehe........thanks!

[~s.o.s~]

then y is it that when i display *p for the 1st time in the main AFTER the function was called, it still manages to display the value or 3?
it only displays rubbish after i try to change the value......

Undefined behaviour. The "it works in this case, so whats wrong with it" thing is not so good to rely on. Since k in your case is an automatic variable whose scope is local to the function you have defined, its existence is and has to be limited to the function block. Any reference to the variable or its location after the function has exited is not to be relied on.

In general, returning the address of the local variable unless you have explicity requested for it (so that you can explicity free it) is a bad progamming practice, resulting in subtle bugs. Better not rely on such things.