Not able to delete a title...help please!

Question

totalnoob 0 Light Poster

15 Years Ago

Hello everyone!
I have a table with titles that have a link to delete the record.
Clicking on the link, redirects the user from (members.php) to a page (delete.php )where it says that the title is deleted and the user can click another link to return to the table. The problem is that the title is never deleted. Could anyone please tell me what's wrong with my code?
This is the table that redirects the user:

echo '<tr>'.
           '<td>'.$row['title'].'</td>'.'<td>'.$row['category'].'</td>'.'<td>'.$row['year'].'</td>'.
           '<td>'.'<font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">
           edit</a></font>'.'</td>'.'<td>'.'<font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font>'.'</td>'.
           '</tr>';

And I've attached the delete.php file.
Thanks in advance!

php

delete.php (0.93 KB)

<html>
<body style="background-color:powderblue;">
      <?php


       include("c:\wamp\www\conf.php");

      

                   if(isset($_GET['autoid']))
                    {
                  $connection=@mysql_connect($host, $user, $pass)or die("Unable to connect!");
                  mysql_select_db($db, $connection) or die ('Unable to select database!');
                   $id=$_GET['autoid'] ;
                $query4= "delete from movie where autoid='$id'";
                $result2=mysql_query($query4) or die ("query failed!");

                     echo "Title deleted";
              ?>
                    </br> </br> </br> </br> </br>
              <?php
                    }
                    else
                    {
                      echo "not deleted!";
                    }
            ?>

                  <a href="members.php">Back to main page</a>


        

</body>
 </html>

4 Contributors
10 Replies
96 Views
10 Hours Discussion Span
Latest Post 15 Years Ago Latest Post by totalnoob

almostbob 866 Retired: passive income ROCKS

15 Years Ago

it is unneccessary, and often makes you miss a quote, to drop in and out of php text for every html tag

echo '<tr><td>'.$row['title'].'</td><td>'.$row['category'].'</td><td>'.$row['year'].'</td>
<td><font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">  edit </a></font></td>
<td><font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font></td></tr>';

when it displays the table, view source to make sure the delet <a href ?parameter is populated with an id, stranger things happen, the error may be in the prior sql query
and $query4= "delete from movie where autoid='$id'"; looks right

BzzBee 5 Posting Whiz

15 Years Ago

try $_REQUEST instead of $_GET

BzzBee 5 Posting Whiz

15 Years Ago

use this code, becuase you dont have form in ur first html section

if(isset($_REQUEST['autoid']))
                    {

                  $connection=@mysql_connect($host, $user, $pass)or die("Unable to connect!");
                  mysql_select_db($db, $connection) or die ('Unable to select database!');
                   $id=$_REQUEST['autoid'] ;
                $query4= "delete from movie where autoid=$id";
                $result2=mysql_query($query4) or die ("query failed!");

                     echo "Title deleted";
              ?>
                    </br> </br> </br> </br> </br>
              <?php
                    }
                    else
                    {
                      echo "not deleted!";
                    }
            ?>

                  <a href="members.php">Back to main page</a>

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

totalnoob 0 Light Poster · Answer 1 · 2009-04-09T19:32:06+00:00

it is unneccessary, and often makes you miss a quote, to drop in and out of php text for every html tag
echo '<tr><td>'.$row['title'].'</td><td>'.$row['category'].'</td><td>'.$row['year'].'</td>
<td><font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">  edit </a></font></td>
<td><font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font></td></tr>';
when it displays the table, view source to make sure the href ?parameter is populated with an id, stranger things happen
and $query4= "delete from movie where autoid='$id'"; if the id is numeric, may not need the single quotes around it in the sql $query4= "delete from movie where autoid=$id";

Hi!
Thanks for your reply! I've tried the query without the single quotes and now it says quey failed in the page.
When I looked in the URL it looked like this:
http://localhost/delete.php?autoid=

There is no id number after autoid. It's like it never recieved a number..

almostbob 866 Retired: passive income ROCKS · Answer 2 · 2009-04-09T19:35:29+00:00

BzzBee nailed it
the field isnt populated if(isset($_REQUEST['autoid']))

totalnoob 0 Light Poster · Answer 3 · 2009-04-09T19:38:23+00:00

use this code, becuase you dont have form in ur first html section

if(isset($_REQUEST['autoid']))
                    {

                  $connection=@mysql_connect($host, $user, $pass)or die("Unable to connect!");
                  mysql_select_db($db, $connection) or die ('Unable to select database!');
                   $id=$_REQUEST['autoid'] ;
                $query4= "delete from movie where autoid=$id";
                $result2=mysql_query($query4) or die ("query failed!");

                     echo "Title deleted";
              ?>
                    </br> </br> </br> </br> </br>
              <?php
                    }
                    else
                    {
                      echo "not deleted!";
                    }
            ?>

                  <a href="members.php">Back to main page</a>

Hi!
Thank you for your reply!
I've tried replacing get to request, but it still says query failed.

mschroeder 251 Bestower of Knowledge Team Colleague · Answer 4 · 2009-04-09T19:47:40+00:00

Then the problem is in the code prior to:

echo '<tr>'.
'<td>'.$row['title'].'</td>'.'<td>'.$row['category'].'</td>'.'<td>'.$row['year'].'</td>'.
'<td>'.'<font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">
edit</a></font>'.'</td>'.'<td>'.'<font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font>'.'</td>'.
'</tr>';

as it doesn't appear to actually be returning an autoid.

totalnoob 0 Light Poster · Answer 5 · 2009-04-09T19:56:24+00:00

totalnoob 0 Light Poster

15 Years Ago

Then the problem is in the code prior to:

echo '<tr>'.
'<td>'.$row['title'].'</td>'.'<td>'.$row['category'].'</td>'.'<td>'.$row['year'].'</td>'.
'<td>'.'<font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">
edit</a></font>'.'</td>'.'<td>'.'<font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font>'.'</td>'.
'</tr>';

as it doesn't appear to actually be returning an autoid.

I'm looking into it right now. Here's the members.php file that has the table, if your interested in seeing it.

members.php (1.48 KB)

<html>
<body style="background-color:powderblue;">

          <?php
          include("c:\wamp\www\login.php");
           include("c:\wamp\www\conf.php");
                  $name2= $_COOKIE["cookiename"];

                  $connection=@mysql_connect($host, $user, $pass)or die("Unable to connect!");
                  mysql_select_db($db, $connection) or die ('Unable to select database!');

                $query2= "select title,category,year,autoid from movie where user='$name2'";
                $result2=mysql_query($query2);

          ?>
           </br> </br> </br> </br> </br>


           <p style"text-align:center;font-size:23"><a name="rubrik">Your proposal:</a></p>
              <font size="2"><a href="add.php" >add title</a></font>
           
            <div style="text-align:center">
           <table width="800" border="1">
                   <th>Title</th><th>Category</th><th>Year</th><th>&nbsp</th><th>&nbsp</th>
           <?php



                while ($row = mysql_fetch_assoc($result2))
               {
      echo '<tr>'.
           '<td>'.$row['title'].'</td>'.'<td>'.$row['category'].'</td>'.'<td>'.$row['year'].'</td>'.
           '<td>'.'<font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">
           edit</a></font>'.'</td>'.'<td>'.'<font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font>'.'</td>'.
           '</tr>';
               }


           ?>

        </table> </div>
</body>
 </html>

totalnoob 0 Light Poster · Answer 6 · 2009-04-09T20:07:52+00:00

I've made small change in the table, just to see if the autoid numbers appeared and it did! I added an extra row.
This is what I did:

while ($row = mysql_fetch_assoc($result2))
               {
      echo '<tr>'.
           '<td>'.$row['title'].'</td>'.'<td>'.$row['category'].'</td>'.'<td>'.$row['year'].'</td>'.
           '<td>'.'<font size="2"><a href="edit.php?autoid="'.$row['autoid'].'">
           edit</a></font>'.'</td>'.'<td>'.'<font size="2"><a href="delete.php?autoid="'.$row['autoid'].'" >delete</a></font>'.'</td>'.
           '<td>'.$row['autoid'].
           '</tr>';
               }

It extracts the autoid number and shows it in the table, but somehow it doesn't pass the value to the url or the query in the other file...

totalnoob 0 Light Poster · Answer 7 · 2009-04-09T22:22:37+00:00

Thank all of you for your replies!
I haven't figured out the problem yet, but I'm going to work with it again later on....
If anyone has figured it out, your more then welcome to reply to the thread... : )