need help with insert.php

Question

nike123 0 Newbie Poster

19 Years Ago

A little help, required with this insert.php script, which is meant to add a new user to mysql user, unfortunately when this script is executed, and username and password inserted, it doesn't actually add the new MYSQL USER, instead i just get the error message .

<?php
if(isset($_POST))
{
include ('config.php');
include ('opendb.php');

mysql_select_db($mysql);
$username = $_POST;
$password = $_POST;

$query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', '$username', PASSWORD('$password'), 'Y', 'Y', 'Y')";
mysql_query($query) or die('Error, insert query failed ');

$query = "FLUSH PRIVILEGES";
mysql_query($query) or die('Error, insert query failed');
include ('closedb.php');
echo "New MySQL user added";
}
else
{
?>
<form method="post">
<table width="400" border="0" cellspacing="1" cellpadding="2">
<tr>
<td width="100">Username</td>
<td><input name="username" type="text" id="username"></td>
</tr>
<tr>
<td width="100">Password</td>
<td><input name="password" type="text" id="password"></td>
</tr>
<tr>
<td width="100"> </td>
<td> </td>
</tr>
<tr>
<td width="100"> </td>
<td><input name="add" type="submit" id="add" value="Add New User"></td>
</tr>
</table>
</form>
<?php

php

5 Contributors
7 Replies
317 Views
3 Years Discussion Span
Latest Post 16 Years Ago Latest Post by phpnukes

Sp!ke 13 Light Poster

19 Years Ago

Well, your code is, shall we say, less than perfect, but, then again, we all have to learn sometime, right? See if this helps:

<?php
if (isset($_POST['add'])) {
   include ('config.php');
   include ('opendb.php');
   
   mysql_select_db('DB_NAME', $mysql);
   // You must tell it what the connection resource is, as well
   // as which databse you will be using. Make sure that in opendb.php,
   // the function mysql_connect(); is being set to $mysql.

   $username = $_POST['username'];
   $password = $_POST['password'];

   $query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', $username, PASSWORD($password), 'Y', 'Y', 'Y')";
   // No single quotes are needed for variables in the statement above.

   mysql_query($query) or die('Error, insert query failed ');

   $query2 = "FLUSH PRIVILEGES";
   mysql_query($query2) or die('Error, insert query failed');

   include ('closedb.php');
   echo "New MySQL user added";
} else {
?>
<html><body>
<form method="post">
<table width="400" border="0" cellspacing="1" cellpadding="2">
<tr> 
<td width="100">Username</td>
<td><input name="username" type="text" id="username"></td>
</tr>
<tr> 
<td width="100">Password</td>
<td><input name="password" type="text" id="password"></td>
</tr>
<tr> 
<td width="100">&nbsp;</td>
<td>&nbsp;</td>
</tr>
<tr> 
<td width="100">&nbsp;</td>
<td><input name="add" type="submit" id="add" value="Add New User"></td>
</tr>
</table>
</form></body></html>

Sp!ke 13 Light Poster

19 Years Ago

Oh, shoot, we're both wrong, heh! ;)

This will most DEFINATELY work.

<?php 
if (isset($_POST['add'])) { 
   include ('config.php'); 
   include ('opendb.php'); 
    
   mysql_select_db('DB_NAME', $mysql); 
   // You must tell it what the connection resource is, as well 
   // as which databse you will be using. Make sure that in opendb.php, 
   // the function mysql_connect(); is being set to $mysql. 

   $username = $_POST['username']; 
   $password = $_POST['password']; 

   $query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', '" . $username . "', 'PASSWORD(" . $password . "'), 'Y', 'Y', 'Y')"; 
   // You need to concatenate with the '.' command.
   // I know this will work, I've used it hunderds of times.

   mysql_query($query) or die('Error, insert query failed '); 

   $query2 = "FLUSH PRIVILEGES"; 
   mysql_query($query2) or die('Error, insert query failed'); 

   include ('closedb.php'); 
   echo "New MySQL user added"; 
} else { 
?> 
<html><body> 
<form method="post"> 
<table width="400" border="0" cellspacing="1" cellpadding="2"> 
<tr> 
<td width="100">Username</td> 
<td><input name="username" type="text" id="username"></td> 
</tr> 
<tr> 
<td width="100">Password</td> 
<td><input name="password" type="text" id="password"></td> 
</tr> 
<tr> 
<td width="100">&nbsp;</td> 
<td>&nbsp;</td> 
</tr> 
<tr> 
<td width="100">&nbsp;</td> 
<td><input name="add" type="submit" id="add" value="Add New User"></td> 
</tr> 
</table> 
</form></body></html>

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

nike123 0 Newbie Poster · Answer 1 · 2005-07-27T06:20:16+00:00

oh yeah, what a stupid mistake. Have not actually changed the database name in my config file. Thanks for pointing that out.

aasahil 0 Newbie Poster · Answer 2 · 2005-07-27T22:05:40+00:00

Just change your insert code with this:

$query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', '$username','$password', 'Y', 'Y', 'Y')";
mysql_query($query) or die('Error, insert query failed ');

I hope this works.
If do so then reply me.
bye.

nike123 0 Newbie Poster · Answer 3 · 2005-10-18T15:20:09+00:00

oh no, thanks for the advice, I got it working ages ago, just got my tutor to look at it for me. Am not too sure how it worked (Not so much of a programming person you see)(

Oh, shoot, we're both wrong, heh! ;)

This will most DEFINATELY work.

<?php 
if (isset($_POST['add'])) { 
   include ('config.php'); 
   include ('opendb.php'); 
    
   mysql_select_db('DB_NAME', $mysql); 
   // You must tell it what the connection resource is, as well 
   // as which databse you will be using. Make sure that in opendb.php, 
   // the function mysql_connect(); is being set to $mysql. 

   $username = $_POST['username']; 
   $password = $_POST['password']; 

   $query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', '" . $username . "', 'PASSWORD(" . $password . "'), 'Y', 'Y', 'Y')"; 
   // You need to concatenate with the '.' command.
   // I know this will work, I've used it hunderds of times.

   mysql_query($query) or die('Error, insert query failed '); 

   $query2 = "FLUSH PRIVILEGES"; 
   mysql_query($query2) or die('Error, insert query failed'); 

   include ('closedb.php'); 
   echo "New MySQL user added"; 
} else { 
?> 
<html><body> 
<form method="post"> 
<table width="400" border="0" cellspacing="1" cellpadding="2"> 
<tr> 
<td width="100">Username</td> 
<td><input name="username" type="text" id="username"></td> 
</tr> 
<tr> 
<td width="100">Password</td> 
<td><input name="password" type="text" id="password"></td> 
</tr> 
<tr> 
<td width="100">&nbsp;</td> 
<td>&nbsp;</td> 
</tr> 
<tr> 
<td width="100">&nbsp;</td> 
<td><input name="add" type="submit" id="add" value="Add New User"></td> 
</tr> 
</table> 
</form></body></html>

hemalatha.a.s 0 Newbie Poster · Answer 4 · 2005-10-19T16:12:46+00:00

hemalatha.a.s 0 Newbie Poster

19 Years Ago

hello

phpnukes 0 Newbie Poster · Answer 5 · 2008-09-24T12:27:24+00:00

This has not been resolved since the original poster found an alternative solution and has not posted back for others.

This is the complete code I am using:

<html>
<head>
<title>Add New MySQL User</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<?php
if(isset($_POST['add']))
{
include 'library/config.php';
include 'library/opendb.php';

$username = $_POST['username'];
$password = $_POST['password'];

$query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', '$username', PASSWORD('$password'), 'Y', 'Y', 'Y')";
mysql_query($query) or die('Error, insert query failed');

$query = "FLUSH PRIVILEGES";
mysql_query($query) or die('Error, insert query failed');

include 'library/closedb.php';
echo "New MySQL user added";
}
else
{
?>
<form method="post">
<table width="400" border="0" cellspacing="1" cellpadding="2">
<tr>
<td width="100">Username</td>
<td><input name="username" type="text" id="username"></td>
</tr>
<tr>
<td width="100">Password</td>
<td><input name="password" type="text" id="password"></td>
</tr>
<tr>
<td width="100">&nbsp;</td>
<td>&nbsp;</td>
</tr>
<tr>
<td width="100">&nbsp;</td>
<td><input name="add" type="submit" id="add" value="Add New User"></td>
</tr>
</table>
</form>
<?php
}
?>
</body>
</html>

I have tried the solutions above but the last one produced a syntax error

There must be a simpler solution

The three external files for these are as follows

1. closedb.php

<?php
//mysql_free_result($result);
mysql_close($conn);
?>

2.config.php

<?php
// db properties
$dbhost = 'localhost';
$dbuser = 'xxxxxxx'; 
$dbpass = 'xxxxxx';
$dbname = 'xxxxxx';
?>

3.opendb.php

<?php
$conn = mysql_connect ($dbhost, $dbuser, $dbpass) or die ('I cannot connect to the database because: ' . mysql_error());
mysql_select_db ($dbname);
?>

I am wondering if the error is here:

$query = "INSERT INTO user (host, user, password, select_priv, insert_priv, update_ priv) VALUES ('localhost', '$username', PASSWORD('$password'), 'Y', 'Y', 'Y')";
mysql_query($query) or die('Error, insert query failed');

INSERT INTO user

I have tried $user and even tried changing the database table name.
On the database there are two tables

user
tbl_auth_user