PHP code not working. Need help

Question

starlight22 0 Newbie Poster

14 Years Ago

My membership script works fine, except I can't login, because this check.php script doesn't work. Login form action is check.php. Once I login with username and password, check.php gives me an error message "Please enter ALL of the information". The only information on login form is username and password. The password is a random md5 password. I copied and paste this script from a php tutortial, because I don't know php. Everything works except this file. How do I direct it to my member page once its working? Please help.

<?
/* Check Username Script */
session_start();  // Start Session

include 'db.php';
// Conver to simple variables
$username = $_POST['username'];
$password = $_POST['password'];

if((!$username) || (!$password)){
	echo "Please enter ALL of the information! <br />";
	include 'login_form.html';
	exit();
}

// Convert password to md5 hash
$password = md5($password);

// check if the user info validates the db
$sql = mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password' AND activated='1'");
$login_check = mysql_num_rows($sql);

if($login_check > 0){
	while($row = mysql_fetch_array($sql)){
	foreach( $row AS $key => $val ){
		$$key = stripslashes( $val );
	}
		// Register some session variables!
		session_register('first_name');
		$_SESSION['first_name'] = $first_name;
		session_register('last_name');
		$_SESSION['last_name'] = $last_name;
		session_register('email_address');
		$_SESSION['email_address'] = $email_address;
		session_register('special_user');
		$_SESSION['user_level'] = $user_level;
		
		mysql_query("UPDATE users SET last_login=now() WHERE userid='$userid'");
		
		header("Location: members.php");
	}
} else {
	echo "You could not be logged in! Either the username and password do not match or you have not validated your membership!<br />
	Please try again!<br />";
	include 'login_form.html';
}
?>

php

Edited 14 Years Ago by nav33n because: Use [code][/code] tags to wrap your code for easy readability.

4 Contributors
8 Replies
120 Views
8 Hours Discussion Span
Latest Post 14 Years Ago Latest Post by rajarajan2017

vaultdweller123 32 Posting Pro

14 Years Ago

where is your log-in form? if you run this directly of course you will encounter an error to enter the field, coz you username and password are empty

vaultdweller123 32 Posting Pro

14 Years Ago

put your code inside $_POST

like

<?
/* Check Username Script */
session_start(); // Start Session

include 'db.php';
// Conver to simple variables
$username = $_POST['username'];
$password = $_POST['password'];

if($_POST['Submit']){ // start of $_POST['Submit']

if((!$username) || (!$password)){
echo "Please enter ALL of the information! <br />";
include 'login_form.html';
exit();
}

// Convert password to md5 hash
$password = md5($password);

// check if the user info validates the db
$sql = mysql_query("SELECT * FROM users WHERE username='$username' AND password='$password' AND activated='1'");
$login_check = mysql_num_rows($sql);

if($login_check > 0){
while($row = mysql_fetch_array($sql)){
foreach( $row AS $key => $val ){
$$key = stripslashes( $val );
}
// Register some session variables!
session_register('first_name');
$_SESSION['first_name'] = $first_name;
session_register('last_name');
$_SESSION['last_name'] = $last_name;
session_register('email_address');
$_SESSION['email_address'] = $email_address;
session_register('special_user');
$_SESSION['user_level'] = $user_level;

mysql_query("UPDATE users SET last_login=now() WHERE userid='$userid'");

header("Location: members.php");
}
} else {
echo "You could not be logged in! Either the username and password do not match or you have not validated your membership!<br />
Please try again!<br />";
include 'login_form.html';
}

} // end of $_POST['Submit']

?>

Edited 14 Years Ago by vaultdweller123 because: n/a

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

starlight22 0 Newbie Poster · Answer 1 · 2010-06-29T14:30:52+00:00

here is th login script.

<html>
<head>
<title>Login</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<form action="check.php" method="post" name="" id="">
  <table width="50%" border="0" align="center" cellpadding="4" cellspacing="0">
    <tr> 
      <td width="22%">Username</td>
      <td width="78%"><input name="username" type="text" id="username"></td>
    </tr>
    <tr> 
      <td>Password</td>
      <td><input name="password" type="password" id="password"></td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
      <td><input type="submit" name="Submit" value="Submit"></td>
    </tr>
  </table>
</form>
</body>
</html>

rajarajan2017 · Answer 2 · 2010-06-29T15:18:32+00:00

if(empty($username) || empty($password)){
echo "Please enter ALL of the information! <br />";
include 'login_form.html';
exit();
}

starlight22 0 Newbie Poster · Answer 3 · 2010-06-29T16:05:06+00:00

I uploaded the code above. After I type username and password on login form I got these error messages.

1. Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by output started at check.php

2. Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent output started at check.php

rajarajan2017 · Answer 4 · 2010-06-29T16:36:15+00:00

session_start(): should be in the first line, Some unwanted characters are added before or after <?php and session_start. Try to identify in some of the editors and remove it. it will work.

pzuurveen 90 Posting Whiz in Training · Answer 5 · 2010-06-29T16:37:19+00:00

haeders are send when ou output something.
so put the sesion stuf before anything else.

also make sure that there are no empty lines before your

no empty line here
<?php 

no echo here

sesion_stuff()
?>

rajarajan2017 · Answer 6 · 2010-06-29T17:01:19+00:00

Use ob_start(); before session_start();