cannot login

Question

raghujosh 0 Junior Poster

13 Years Ago

I have a simple login module wherein I enter login info to a database. After that, I use another file, loginauth.php which validates the login info. However, I am getting the else statement executed. Can somebody point out what's wrong.

<?php
session_start();

if (isset($_POST['userid']) && isset($_POST['password']))
{
$userid = trim($_POST['userid']);
$password = trim($_POST['password']);
$con = new mysqli("internal-db.s110820.gridserver.com","db110820","Solved!2$$");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }



$query = "SELECT * from Login WHERE trim(email) = '$userid' and trim(password) = '$password'";

$result = $con->query($query);
if ($result->num_rows)
{
$_SESSION['valid_user']=$userid;
}
$con->close();
}
?>

<html>
<body>
<h1>Home Page<h2>
<?php
if (isset($_SESSION['valid_user']))
{
echo 'You are logged in as : '.$_SESSION['valid_user'].' <br/>';
echo '<a href = "logout.php">Log out</a><br>';
}
else 
{
if (isset($userid))
{
echo 'Could not log you in . <br/>';
}
}


?>

</body>
</html>

php

3 Contributors
12 Replies
117 Views
1 Day Discussion Span
Latest Post 13 Years Ago Latest Post by raghujosh

diafol

13 Years Ago

I don't know the specifics of your 'mysql' object, but this may need a look:

$result->num_rows

Does it need to be?

$result->num_rows > 0

I can't see that it would be wrong, but ...

diafol

13 Years Ago

$info = mysql_fetch_array( $result );
echo "Print".$info."Print";

You can't this, as it's not a string. You need to access the individual field, e.g. $info or $info.

diafol

13 Years Ago

Looks like OOP-style mysqli - I must have missed that in the first post. Sorry, can't help you, I have no experience of it (nor wish to I'm afraid). Anybody else?

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

raghujosh 0 Junior Poster · Answer 1 · 2011-02-27T07:28:40+00:00

I don't know the specifics of your 'mysql' object, but this may need a look:
$result->num_rows
Does it need to be?
$result->num_rows > 0
I can't see that it would be wrong, but ...

Sorry, but this did not work. I have ut the following debugging code in my script. When I execute that I get the following error

$info = mysql_fetch_array( $result );
echo "Print".$info."Print";

the error it generates is Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in

I am now doubting if my SQL query is right. Can you pls take a second look at my sql query?
Thanks
Raghu

raghujosh 0 Junior Poster · Answer 2 · 2011-02-27T21:13:37+00:00

$info = mysql_fetch_array( $result );
echo "Print".$info."Print";
You can't this, as it's not a string. You need to access the individual field, e.g. $info or $info.

either way, the error remains the same. I am not getting any output.

raghujosh 0 Junior Poster · Answer 3 · 2011-02-27T21:28:08+00:00

either way, the error remains the same. I am not getting any output.

I changed the following piece of code

$result = $con->query($query);

to

$result = $con->query($query)or die(mysql_error());

Now the error warning is gone, but still it does not appear to go into the if loop and display "u r logged in " message.

raghujosh 0 Junior Poster · Answer 4 · 2011-02-27T22:01:26+00:00

Looks like OOP-style mysqli - I must have missed that in the first post. Sorry, can't help you, I have no experience of it (nor wish to I'm afraid). Anybody else?

I will try and change it to the procedural way. let me see how it goes.

raghujosh 0 Junior Poster · Answer 5 · 2011-02-27T23:28:25+00:00

Looks like OOP-style mysqli - I must have missed that in the first post. Sorry, can't help you, I have no experience of it (nor wish to I'm afraid). Anybody else?

I changed the code from OOP style to procedural style. Now everthing is fine.
My final code looks as follows

<?php
session_start();
if (isset($_POST['userid']) && isset($_POST['password']))
{
$userid = trim($_POST['userid']);
$password = trim($_POST['password']);
}
$con = mysql_connect("internal-db.s110820.gridserver.com","db110820","Solved!2$$");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("db110820_AppCreator", $con);

$query = "SELECT * from Login WHERE trim(email) = '$userid' and trim(password) = '$password'";

$result = mysql_query($query);
while($info = mysql_fetch_array($result))
   { 
echo $info['email'];
    echo $info['password'];
}  

$num_rows = mysql_num_rows($result);



echo $num_rows;


if($num_rows >0)
{

$_SESSION['valid_user']=$userid;

}
mysql_close($con)

?>

<html>
<body>
<h1>Home Page<h2>
<?php
if (isset($_SESSION['valid_user']))
{
echo 'You are logged in as : '.$_SESSION['valid_user'].' <br/>';
echo '<a href = "logout.php">Log out</a><br>';
}
else 
{
if (isset($userid))
{
echo 'Could not log you in . <br/>';
}
}


?>

</body>
</html>

Thanks ardav for all your help

kekkaishi 18 Junior Poster · Answer 6 · 2011-02-27T23:35:51+00:00

if i may add in, a couple of points. (refering to ur original code)
1-

$con = new mysqli("internal-db.s110820.gridserver.com","db110820","Solved!2$$"); //is only the connetion. the database needs to be selected
$con->select_db("dbname");

2- the way u've coded mysqli_stmt::num_rows wont work i think. u first need to store the result if u wanna use num_rows. otherwise num_rows will return 0 always. eg usage:

$qry = "select * from login where trim(email)='{$email}' and password = '{$pass}'";
$result = $con->prepare($qry);
$result->execute();
$result->store_result();
if($result->num_rows){
 .
 .
//as ardav suggested id also suggest to use num_rows>0 or num_rows==1 
}

u could also use the code u r using, but instead of num_rows, use affected_rows
i.d

if($con->affected_rows ==0){
//do task
//BUT still u needa select the db. 
}

hope this helps.

raghujosh 0 Junior Poster · Answer 7 · 2011-02-28T01:00:55+00:00

if i may add in, a couple of points. (refering to ur original code)
1-
$con = new mysqli("internal-db.s110820.gridserver.com","db110820","Solved!2$$"); //is only the connetion. the database needs to be selected
$con->select_db("dbname");
2- the way u've coded mysqli_stmt::num_rows wont work i think. u first need to store the result if u wanna use num_rows. otherwise num_rows will return 0 always. eg usage:
$qry = "select * from login where trim(email)='{$email}' and password = '{$pass}'";
$result = $con->prepare($qry);
$result->execute();
$result->store_result();
if($result->num_rows){
 .
 .
//as ardav suggested id also suggest to use num_rows>0 or num_rows==1 
}
u could also use the code u r using, but instead of num_rows, use affected_rows
i.d
if($con->affected_rows ==0){
//do task
//BUT still u needa select the db. 
}
hope this helps.

Thanks. Your points noted. Yes, I was not selecting the DB, but I am doing so in the procedural way. Procedural to OOP is daunting.

diafol · Answer 8 · 2011-02-28T03:35:45+00:00

Sorry, just to clarify, you started using mysqli - which I've never used. MySQL OOP is not something I'd want to discourage anybody from using. Sorry if I gave that impression.

raghujosh 0 Junior Poster · Answer 9 · 2011-02-28T03:47:25+00:00

Sorry, just to clarify, you started using mysqli - which I've never used. MySQL OOP is not something I'd want to discourage anybody from using. Sorry if I gave that impression.

No problem. I also did not mean that OOP style was the problem. OOP in PHP is new and so difficult to troubleshoot.