<html>
<body>
<?php
$con = mysql_connect("localhost","root","");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db("mydb", $con);
$sql="INSERT INTO users(firstname, lastname)
VALUES
('$_POST[firstname]','$_POST[lastname]')";
if (!mysql_query($sql,$con))
{
die('Error: ' . mysql_error());
}
echo "1 record added";
mysql_close($con)
?>
</body>
</html>
SirMahlon 0 Junior Poster in Training
broj1 356 Humble servant Featured Poster
Check first whether $_POST values exist (they usually do not on the first page load). And also it is very important to escape the values before inserting into the database.
// check if values exist
if(isset($_POST[firstname]) and isset($_POST[lastname])) {
$con = mysql_connect("localhost","root","");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db("mydb", $con);
// escape the values (to minimize a chance of SQL injection)
$firstname = mysql_real_escape_string($_POST[firstname]);
$lastname = mysql_real_escape_string($_POST[lastname]);
// then use escaped values in your query
$sql="INSERT INTO users(firstname, lastname) VALUES ('$firstname','$lastname')";
...
...
mysql_close($con);
}
Also ASAP switch to more up to date DB extension such as mysqli or PDO.
SirMahlon 0 Junior Poster in Training
thanks.but am now getting a new error use of undefined constants on line 2.what might be the problem
broj1 356 Humble servant Featured Poster
Sory, my mistake, forgot the quotes in array indexes. This is correct:
$firstname = mysql_real_escape_string($_POST['firstname']);
$lastname = mysql_real_escape_string($_POST['lastname']);
SirMahlon 0 Junior Poster in Training
still get the same error after adding the qoutes please.
broj1 356 Humble servant Featured Poster
What is the code on line 2?
SirMahlon 0 Junior Poster in Training
if(isset($_POST[firstname]) and isset($_POST[lastname])) {
broj1 356 Humble servant Featured Poster
OK, the quotes are missing in this line also. Try:
if(isset($_POST['firstname']) && isset($_POST['lastname'])) {
SirMahlon 0 Junior Poster in Training
now i don't get any error but no data is sent into the tables users with databse name mydb.
thanks a lot by the way
broj1 356 Humble servant Featured Poster
Echo the query and test it in phpmyadmin (or post it here). Put this temporary debug line somewhere (like line 11 in your original post):
die("INSERT INTO users(firstname, lastname) VALUES ('$firstname','$lastname')");
This will display the constructed query and stop the script. Now copy it to phpmyadmin and see what happens. You can post the output here.
SirMahlon 0 Junior Poster in Training
<?php
// check if values exist
if(isset($_POST['firstname']) && isset($_POST['lastname'])) {
$con = mysql_connect("localhost","root","");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db('mydb', $con);
// escape the values (to minimize a chance of SQL injection)
$firstname = mysql_real_escape_string($_POST['firstname']);
$lastname = mysql_real_escape_string($_POST['lastname']);
// then use escaped values in your query
$sql='INSERT INTO users(firstname,lastname) VALUES ("$firstname","$lastname")';
if (!mysql_query($sql,$con))
{
echo $sql;
}
else
{
die('Error: ' . mysql_error());
}
echo "1 record added";
mysql_close($con);
}
?>
SirMahlon 0 Junior Poster in Training
still the same.no error but the data does not get in there
broj1 356 Humble servant Featured Poster
Can you post the code for the form? There might be an error there.
SirMahlon 0 Junior Poster in Training
<html>
<body>
<h1>A small example page to insert some data in to the MySQL database using PHP</h1>
<form action="insert.php" method="post">
Firstname: <input type="text" name="fname" /><br><br>
Lastname: <input type="text" name="lname" /><br><br>
<input type="submit" />
<?php
?>
</form>
</body>
</html>
SirMahlon 0 Junior Poster in Training
this is the form code please
broj1 356 Humble servant Featured Poster
The input name attributes should be the same as indexes in the $_POST array so change the form to:
Firstname: <input type="text" name="firstname" /><br><br>
Lastname: <input type="text" name="lastname" /><br><br>
(or if you prefer change the indexes in the $_POST array).
SirMahlon 0 Junior Poster in Training
not working still sir.i want to post both codes for you to examine pls.
SirMahlon 0 Junior Poster in Training
<?php
// check if values exist
if(isset($_POST['fname']) && isset($_POST['lname'])) {
$con = mysql_connect("localhost","root","");
if (!$con)
{
die('Could not connect: ' . mysql_error());
}
mysql_select_db('mydb', $con);
// escape the values (to minimize a chance of SQL injection)
$fname = mysql_real_escape_string($_POST['fname']);
$lname = mysql_real_escape_string($_POST['lname']);
// then use escaped values in your query
$sql="INSERT INTO users(fname,lname) VALUES ('$_POST[fname]','$_POST[lname]')";
if (!mysql_query($sql,$con))
{
echo $sql;
}
else
{
die('Error: ' . mysql_error());
}
echo "1 record added";
mysql_close($con);
}
?>
SirMahlon 0 Junior Poster in Training
this is for the form.my browser echo's my sql statement but does not get into the database
SirMahlon 0 Junior Poster in Training
<html>
<body>
<h1>A small example page to insert some data in to the MySQL database using PHP</h1>
<form action="insert.php" method="post">
Firstname: <input type="text" name="fname" /><br><br>
Lastname: <input type="text" name="lname" /><br><br>
<input type="submit" />
</form>
</body>
</html>
x
broj1 356 Humble servant Featured Poster
What is the output of the echo command on line 17?
And change the query to use escaped values:
$sql="INSERT INTO users(fname,lname) VALUES ('$fname','$lname')";
And to be on safe side put a space after database name:
$sql="INSERT INTO users (fname,lname) VALUES ('$fname','$lname')";
SirMahlon 0 Junior Poster in Training
thanks boss.issue resolved.
broj1 356 Humble servant Featured Poster
Glad to hear that. Please mark thread as solved. Happy coding.
Be a part of the DaniWeb community
We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.