Edit profile page

[shany0786]

There is no problem in my code it's running fine but i want some suggestion.I have edit profile page for user when user is login he can click on edit profile button to edit his profile but i have what i we generally see is when user click on edit profile url must have like www.example.com/edit/user_id=1 or something similar like where in url there is always user id is present.I developed a edit page it has url like http://localhost/ko/Update_profile/get_user_data when log in user is has this url it can edit his profile so i have doubt is i am doing something wrong ??

I am using Codeigniter

[ihelpyou]

Hi shany0786,
i think you are going in right way but your saying that you were using codeigniter framework right
so please have a lok at your code in get_user_data.php[file something like this in your project ] like how that page accessing the inputs from ui by using post parameters or some other way.

if you go this way you will find the answer

all the best

correct me if i am wrong.

[diafol]

You can certainly do it like this, however, you MUST check that the user_id in the url is the same as that held in the session user_id, otherwise a miscreant would be able to edit anybody's profile just ny changing the url and pressing enter!
Most modern sites use mod_rewriting / RESTful API to do this type of thing, so profiles/1/edit would be a suitable url.
In addition:

 http://localhost/ko/Update_profile/get_user_data

Could also work for you, but there you will be taking the user_id directly from the session data, not the url. I haven't used CI for a few years and I can't remember using pretty urls like Laravel does (via routing file). Think about all the pages you have and formulate a url strategy - i.e. are they all going to be custom or are you going to develop a CRUD-type system,e.g.

users/create
users/34/edit
users/34/update
users/34/delete
users/34/view

where 34 = the user's id.

[shany0786]

yeah i am taking user_id from session actually there is no user_id it's just http://localhost/ko/Update_profile/get_user_data who ever is login when click on edit page will be directed to this url however i also noticed by daniweb edit profile is also same https://www.daniweb.com/members/edit_profile ?

[shany0786]

this is my Controller Update_profile.php

<?php
if ( ! defined('BASEPATH')) exit('No direct script access allowed');

class Update_profile extends CI_Controller {

public  function __construct()
     {
          // Call the Model constructor
          parent::__construct();
        $this->load->library('session');
        // Load validation library
        $this->load->library('form_validation');
        $this->load->model('Edit_profile');
    }
public function get_user_data() {
if($this->session->userdata['sessiondata']['user_id'] !=null) {
$id=$this->session->userdata['sessiondata']['user_id'];
$result=$this->Edit_profile->get_user_data($id);
$result=$result[0];
//die(var_dump($result));
$this->load->view('header');
$this->load->view('edit_profile',$result);
} 
else {

            redirect(base_url("HomeController/index"));      
     }  

}





}

my Model

<?php 
if ( ! defined('BASEPATH')) exit('No direct script access allowed');

class Edit_profile extends CI_Model {


public function get_user_data($id) {

$sql="
      SELECT * FROM tbl_usrs where user_id='{$id}' "; 
$query = $this->db->query($sql);
$result = $query->result_array();
return $result;
}



} //class ends

[diafol]

Ok, so what do you need now?

[shany0786]

Is my approach right or something is wrong with that can i have some links how to do it in correct way??