I give up

Question

SethR 0 Light Poster

18 Years Ago

:sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad: :sad:

php

3 Contributors
21 Replies
240 Views
19 Hours Discussion Span
Latest Post 18 Years Ago Latest Post by Lafinboy

Dani 4,329 The Queen of DaniWeb

18 Years Ago

PHP problems, Seth?

Lafinboy 4 Junior Poster

18 Years Ago

Well I've got a beer in front of me, all I need it a sad story so I can start crying into it:D

As my old grandmother used to say - "a problem shared is a problem halved" - so come on, let's have it!

Lafinboy 4 Junior Poster

18 Years Ago

You've got the logic path mixed up, so you will always get a 0 score. Change:

$score = 0;
$total = mysql_num_rows($result);
$finalScore = $score * 10; // this line needs to moved

while ($row = mysql_fetch_array($result))
{
$question = $result["question"];
$answer = $row["answer"];
$ans1 = $result["ans1"];
$ans2 = $result["ans2"];
$id = $result["id"];
if ($id['value'] == $answer)
{
$score++;
}
}

to:

$score = 0;
 $total = mysql_num_rows($result);

 while ($row = mysql_fetch_array($result))
 {
 $question = $result["question"];
 $answer = $row["answer"];
 $ans1 = $result["ans1"];
 $ans2 = $result["ans2"];
 $id = $result["id"];
 if ($id['value'] == $answer)
 {
 $score++;
 }
}

 $finalScore = $score * 10; // this is where it needs to be

Lafinboy 4 Junior Poster

18 Years Ago

After a closer look, you don't seem to be collecting the posted values from the form page, and so are not comparing them to your database values at any point.

Try this:

<?php
$link = mysql_connect("localhost", "web26", "web9660!", "sere1")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $sql");

mysql_select_db("sere1", $link);

$result = "Select id, answer from quiz1 limit 0,3";
$result = mysql_query($result) or die(mysql_error());

$score = 0;
$total = mysql_num_rows($result);

while ($row = mysql_fetch_array($result))
{
$answer = $row["answer"];
$id = $row["id"];
if ($_REQUEST['id'] == $answer)
{
$score++;
}
}

$finalScore = $score * 10;
?>

SethR commented: goes out of his way to help +1

Lafinboy 4 Junior Poster

18 Years Ago

OK, so put a bit of debug echo into the while loop to see what values are being passed through the form, what the database is sayinh the answer is, and whether they should in fact match up.

while ($row = mysql_fetch_array($result))
{
$answer = $row["answer"];
$id = $row["id"];
// start debug output
echo "db id = $id | db answer = $answer | form answer = ".$_REQUEST['id']."<br>";
// end debug output
if ($_REQUEST['id'] == $answer)
{
$score++;
}
}

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

SethR 0 Light Poster · Answer 1 · 2006-08-08T08:18:15+00:00

SethR 0 Light Poster

18 Years Ago

you don't know the half of it : (

SethR 0 Light Poster · Answer 2 · 2006-08-08T08:39:46+00:00

for some reason my grade.php is always giving me a score of zero.....

here's my code..two pages.....takeTest.php and grade.php

<?

$link = mysql_connect("localhost", "web26", "web9660!", "sere1")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $sql");
print("Connected successfully");
mysql_select_db("sere1", $link);

$result = "Select * from quiz1 order by rand() limit 0,3";
$result = mysql_query($result) or die(mysql_error());
$num_results= mysql_num_rows($result);
echo "<form method=post action='grade.php'>";
echo "<table border=1 bgcolor=lime>";

while ($row = mysql_fetch_array($result)){
$id = $row;
$question = $row["question"];
$ans1 = $row["ans1"];
$ans2 = $row["ans2"];
$answer = $row["answer"];

echo "<tr><td colspan=3><br><b>$question</b></td></tr>";
echo "<tr><td>$ans1 <input type=radio name='$id' value='$ans1'></td><td>$ans2 <input type=radio name='$id' value='$ans2'></td></tr>";

}
echo "</table>";

echo "<input type='submit' value='Get Grade' name='submit'>";

echo "</form>";

?>

</center>
</body>
</html>

Here's grade.php.....

<html>
<head>
<title>Grade</title>
</head>
<body bgcolor ="yellow">
<center>

<?php

$link = mysql_connect("localhost", "web26", "web9660!", "sere1")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $sql");

mysql_select_db("sere1", $link);

$result = "Select * from quiz1 order by rand() limit 0,3";
$result = mysql_query($result) or die(mysql_error());

$score = 0;
$total = mysql_num_rows($result);
$finalScore = $score * 10;

while ($row = mysql_fetch_array($result))
{
$question = $result["question"];
$answer = $row["answer"];
$ans1 = $result["ans1"];
$ans2 = $result["ans2"];
$id = $result["id"];
if ($id == $answer)
{
$score++;
}

}

?>
<?
echo " you scored $finalScore<br>";

?>
</center>
</body>
</html>
Here's the link to takeTest.php

http://cisweb.bristol.mass.edu/~web2...t/takeTest.php

SethR 0 Light Poster · Answer 3 · 2006-08-08T09:08:12+00:00

thanks.....but I'm still coming up with a score of 0.

http://cisweb.bristol.mass.edu/~web26/week13assignment/takeTest.php

SethR 0 Light Poster · Answer 4 · 2006-08-08T09:30:01+00:00

Thanks again.....but I'm still getting a big fat goose egg for my score.

SethR 0 Light Poster · Answer 5 · 2006-08-08T09:45:22+00:00

I actully did that with an echo "$answer"; earlier and they were matching up......but still gave a grade of zero.

Lafinboy 4 Junior Poster · Answer 6 · 2006-08-08T09:55:13+00:00

Probably because your code was wrong at that time. What is the debug output now? And can you post the full code to the grade.php page as you now have it.

SethR 0 Light Poster · Answer 7 · 2006-08-08T09:57:59+00:00

sure ..... here's grade.php

<html>
<head>
<title>Grade</title>
</head>
<body bgcolor ="yellow">
<center>

<?php

$link = mysql_connect("localhost", "web26", "web9660!", "sere1")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $result");

mysql_select_db("sere1", $link);

$result = "Select * from quiz1 order by rand() limit 0,3";
$result = mysql_query($result) or die(mysql_error());

$score = 0;
$total = mysql_num_rows($result);
$finalScore = $score * 10; // this line needs to moved

while ($row = mysql_fetch_array($result))
{
$question = $result["question"];
$answer = $row["answer"];
$ans1 = $result["ans1"];
$ans2 = $result["ans2"];
$id = $result["id"];
if ($id == $answer)
{
$score++;
}
echo "$answer";

}
echo "$finalScore";
?>
</center>
</body>
</html>

Lafinboy 4 Junior Poster · Answer 8 · 2006-08-08T10:05:36+00:00

You haven't made any of the changes to the code I previously posted. Implement the changes I posted and it WILL work.

SethR 0 Light Poster · Answer 9 · 2006-08-08T10:09:07+00:00

just changed it if you want to take a look at the results.

http://cisweb.bristol.mass.edu/~web26/week13assignment/takeTest.php

Lafinboy 4 Junior Poster · Answer 10 · 2006-08-08T10:13:28+00:00

Noticed a typo in the code i posted. Change all instances of:

$_REQUEST['id']

to:

$_REQUEST[$id]

SethR 0 Light Poster · Answer 11 · 2006-08-08T10:18:38+00:00

done.....think we might be getting somewhere now.

Lafinboy 4 Junior Poster · Answer 12 · 2006-08-08T10:54:48+00:00

OK, so the page now shows the debug info correctly, and is showing that the values from the form are not being populated correctly. I've copied everything locally (including your database - you should go back and edit out your username/password from the original post) and it works fine. So there is likely a typo or missed piece of code in your script.

Post it again, exactly as you have it now, and I'll post it back with any corrections so you can copy it straight in.

SethR 0 Light Poster · Answer 13 · 2006-08-08T17:49:01+00:00

<?

$link = mysql_connect("localhost", "****", "*****", "*****")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $sql");
print("Connected successfully");
mysql_select_db("sere1", $link);

$result = "Select * from quiz1 order by rand() limit 0,3";
$result = mysql_query($result) or die(mysql_error());
$num_results= mysql_num_rows($result);
echo "<form method=post action='grade.php'>";
echo "<table border=1 bgcolor=lime>";
while ($row = mysql_fetch_array($result)){

$id = $row;
$question = $row["question"];
$ans1 = $row["ans1"];
$ans2 = $row["ans2"];
$answer = $row["answer"];

echo "<tr><td colspan=3><br><b>$question</b></td></tr>";
echo "<tr><td>$ans1 <input type=radio name='$id' value='TRUE'></td><td>$ans2 <input type=radio name='$id' value='FALSE'></td></tr>";

}
echo "</table>";

echo "<input type='submit' value='Get Grade' name='submit'>";

echo "</form>";

?>

</center>
</body>
</html>

<html>
<head>
<title>Grade</title>
</head>
<body bgcolor ="yellow">
<center>

<?php

$link = mysql_connect("localhost", "****", "****", "****")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $result");

mysql_select_db("sere1", $link);

$result = "Select * from quiz1 order by rand() limit 0,3";
$result = mysql_query($result) or die(mysql_error());

$score = 0;
$total = mysql_num_rows($result);

while ($row = mysql_fetch_array($result))
{
$answer = $row["answer"];
$id = $row["id"];
// start debug output
echo "db id = $id | db answer = $answer | form answer = ".$_REQUEST."<br>";
// end debug output
if ($_REQUEST == $answer)
{
$score++;
}
}
$finalScore = $score * 10; // this line needs to moved
echo "$finalScore";
?>
</center>
</body>
</html>

Lafinboy 4 Junior Poster · Answer 14 · 2006-08-08T18:22:32+00:00

Replace grade.php with this:

<?php

$link = mysql_connect("localhost", "****", "****", "****")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $result");

mysql_select_db("sere1", $link);


$result = "Select * from quiz1 order by  rand() limit 0,3"; 
$result = mysql_query($result) or die(mysql_error());


$score = 0;
$total = mysql_num_rows($result);

while ($row = mysql_fetch_array($result))
{
$answer = $row["answer"];
$id = $row["id"];
// start debug output
echo "db id = $id | db answer = $answer | form answer = ".$_REQUEST[$id]."<br>";
// end debug output
if ($_REQUEST[$id] == $answer)
{
$score++;
}
} 
$finalScore = $score * 10; // this line needs to moved
echo "$finalScore";
?> 
</center>
</body>
</html>

There were quote marks around the $id var in the $_REQUEST call.

SethR 0 Light Poster · Answer 15 · 2006-08-08T18:52:52+00:00

Replace grade.php with this:

<?php

$link = mysql_connect("localhost", "****", "****", "****")
or die("Error ".mysql_errno().": ".mysql_error()."<br>\nThe SQL sent was: $result");

mysql_select_db("sere1", $link);


$result = "Select * from quiz1 order by  rand() limit 0,3"; 
$result = mysql_query($result) or die(mysql_error());


$score = 0;
$total = mysql_num_rows($result);

while ($row = mysql_fetch_array($result))
{
$answer = $row["answer"];
$id = $row["id"];
// start debug output
echo "db id = $id | db answer = $answer | form answer = ".$_REQUEST[$id]."<br>";
// end debug output
if ($_REQUEST[$id] == $answer)
{
$score++;
}
} 
$finalScore = $score * 10; // this line needs to moved
echo "$finalScore";
?> 
</center>
</body>
</html>

There were quote marks around the $id var in the $_REQUEST call.

Lafin Boy RULES! Thank you very much for your help!

Lafinboy 4 Junior Poster · Answer 16 · 2006-08-08T21:25:03+00:00

Lafinboy 4 Junior Poster

18 Years Ago

Happy to help.