Member Avatar for afg_91320 
int table [10];
      for (int x = 0; x < 20, x++)
      {
          cout << “Enter the next value: “;
          cin >> table [x]
       }

is it at the cin line? and im not sure if a semicolon is needed.
thanks:icon_cheesygrin:

  • 3 Contributors
  • 2 Replies
  • 91 Views
  • 7 Hours Discussion Span
  • Latest Post Latest Post by dickersonka

Dani AI

Generated

The snippet has a few independent issues. is right that statements like the input need a terminating semicolon; is right that indexing past the array size is undefined behavior. In addition, the for header uses the wrong separator and the prompt uses typographic quotes that the compiler will not accept.

Key problems and fixes (concise):

  • The for header must follow the form for (init; condition; increment). Using a comma instead of the semicolon either produces a syntax error or invokes the comma operator and changes the logic. Use the correct separators and pick a condition that matches the array length (for example, stop at the array size).
  • Use plain ASCII double quotes for string literals; typographic quotes are invalid in source.
  • Every simple statement needs a semicolon (for example, the input statement must end with ;).
  • Do not iterate past the array bounds — writing beyond index 9 for a 10-element array causes undefined behavior. Either reduce the loop limit or use a larger container.

Safer patterns and runtime checks:

  • Prefer std::vector or std::array and loop using the container’s size() or a range-based loop so you do not hard-code limits. Validate input with if (!(cin >> value)) and handle failures (clear and ignore the rest of the line).
  • Enable strong compiler diagnostics (-Wall -Wextra -std=c++17) and use runtime tools like AddressSanitizer to catch out-of-bounds and UB.

Useful references: the for statement and std::vector documentation for safe container and loop usage.

Recommended Answers

All 2 Replies

Member Avatar for Narue

>im not sure if a semicolon is needed.
The basic guideline is that the semicolon is a statement terminator, so unless you're working with a compound statement (where braces surround zero or more statements), you need to finish with a semicolon. That's why you don't need a semicolon after this if statement:

if ( [I]<condition>[/I] ) {
  // ...
}

But you do need it with a simple statement like cin >> table [x]; . It's admittedly confusing at first, but you'll get it with practice.

Member Avatar for dickersonka

also you will crash out past once x hits 10, your table is only of size 10

commented: Good catch =) +4
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.