Member Avatar for MJV

If I have code that is executed by a button statement and I would like this code to be executed at different times from other actions can I use a goto stateent to execute it? If so how. I can't seem to find a correct way or method to label the code that is executed so the goto statement is correct.

My code looks like this. How would I name my goto statement to get here. Thanks in advance.

private void calculateBN_Click(object sender, EventArgs e)
{
"calculations"
}

  • 4 Contributors
  • 6 Replies
  • 115 Views
  • 21 Hours Discussion Span
  • Latest Post Latest Post by Rashakil Fol

Dani AI

Generated

Short answer: do not use goto for this. Extract the reusable logic into a method and call that method from whatever event handlers or places need it. That is what and were recommending, and showed the same approach in his example. goto can only jump inside a single method and is almost never the right tool for sharing behavior; see the language reference for the goto keyword for details: goto statement (C#).

A practical pattern:

  • Move the calculation into a small method that takes inputs and returns results (avoid tightly coupling it to UI controls).
  • Call that method from the button click and from any other place that needs the same behavior.
  • Keep UI parsing/formatting in the event handler so the core method is easy to test and reuse.

Example (illustrative):

private int ComputeTotal(int itemA, int itemB)
{
    return itemA + itemB;
}

private void ButtonCalculate_Click(object sender, EventArgs e)
{
    int a = ParseInput(txtA.Text);
    int b = ParseInput(txtB.Text);
    txtTotal.Text = ComputeTotal(a, b).ToString();
}

Avoid calling an event handler directly as a way to reuse logic; call the shared method instead. In ASP.NET you also need to respect the page lifecycle and postback model (reading control values at the right time). For more on defining and calling methods in C# see the official guide: Methods (C# programming guide).

Checklist: extract, give the method clear parameters/return, keep UI code separate, call the method from any handler. This is cleaner, testable, and what experienced posters here were pointing toward.

Recommended Answers

All 6 Replies

Member Avatar for Rashakil Fol

Put the code you want in a function and call the function. You can't use goto statements across functions -- that wouldn't even make any sense.

Member Avatar for LizR

Its a bad habbit to use gotos without purpose (which that would be)

simple answer

Make a method

when you need it, call the method, wether its from that action or from your other code.

Member Avatar for MJV

Im new at programming. How do you call the method.

Member Avatar for LizR

Wow, did you really just ask that?
So you in your code you only now how to add things up and set values?

Member Avatar for sknake

This illustrates having each method (also called a procedure or function in other languages) having a single task that way you can call the code from anywhere (eliminating the need for a goto). If this doesn't address how you can solve your problem then you need to post the code you currently have and outline your problem.

Goto is a hack for allowing bad design and is not a best practice in use or concept.

buttonSave_click(object sender, eventargs e)
{
  CalculateTotals();
  SaveInvoice();
  this.Close();
}

buttonRecalculate_Click(object sender, eventargs e)
{
  CalculateTotals();
}

private void CalculateTotals()
{
  decimal serviceAmt = decimal.Parse(textEditService.Text);
  decimal productAmt = decimal.Parse(textEditProducts.Text);
  textEditTotalAmt.Text = Convert.ToString(serviceAmt+productAmt);
}

private void SaveInvoice()
{
  dsInvoice[0]["ServiceAmt"] = decimal.Parse(textEditService.Text);
  dsInvoice[0]["ProductAmt"] = decimal.Parse(textEditProducts.Text);
  dsInvoice[0]["Total"] = decimal.Parse(textEditService.Text)+ decimal.Parse(textEditProducts.Text);
}
Member Avatar for Rashakil Fol

Im new at programming. How do you call the method.

You really just need to learn how to program. Follow whatever book or high quality tutorial you're using and burn through the basics.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.