Member Avatar for SoulMazer

Hi, I'm new to C++ and I'm having trouble with this dang linker error. The full error is as follows:

Error 4 error LNK2001: unresolved external symbol "public: static class std::list<class Node,class std::allocator<class Node> > NodeManager::node_list" (?node_list@NodeManager@@2V?$list@VNode@@V?$allocator@VNode@@@std@@@std@@A) Nodes.obj

Error 5 fatal error LNK1120: 1 unresolved externals

From this error, I have deduced that the problem is with NodeManager::node_list. After doing a little researching, I have found that LNK2001 refers to an undefined object, right? I do define node_list as a static member of NodeManager, so I'm not quite sure what's wrong.

Here's some code (I cut it short for brevity's sake):

Node.h

#ifndef NODES_H
#define NODES_H

#include <vector>
#include <list>

class Node {
public:
	std::vector<int> children;

	Node(int num, float x, float y, float z) {
		num_ = num;
		x_ = x;
		y_ = y;
		z_ = z;
	}

private:
	int num_;
	float x_;
	float y_;
	float z_;
};

class NodeManager {
public:
	static std::list<Node> node_list;
};

void generateNodes();

#endif

Node.cpp

#include "Nodes.h"

#include <list>

void generateNodes() {
	Node n1(1, 346.0, 26.5, -470.0);
	n1.children.push_back(2);
	n1.children.push_back(4);
	n1.children.push_back(5);
	NodeManager::node_list.push_back(n1);

	// defining more nodes
}

The only reason I created a NodeManager class is because I need a list to keep track of my node list, and I was told that you cannot create, for example, a list of Node's within the Node definition. Is this correct?

Any ideas? Also, feel free to provide constructive criticism.

Thanks in advance.

  • 2 Contributors
  • 4 Replies
  • 333 Views
  • 6 Hours Discussion Span
  • Latest Post Latest Post by SoulMazer

Dani AI

Generated

Good call by — that linker message means the static member was declared but never given a single definition the linker can find. A declaration in a header only tells each translation unit the member exists; you still need exactly one definition (one object) somewhere the linker sees. Including the header from many files does not “reset” the value — it only provides the declaration to each TU.

If the error persists after adding a definition, check these quick points: make sure the .cpp that contains the definition is actually part of the build and linked; ensure the definition matches the declaration exactly (same class, same namespace and template parameters); avoid accidental multiple non-inline definitions across TUs (ODR violations); and verify there aren’t subtle mismatches like differing const/volatile or extern "C" mismatches.

Two safer alternatives worth considering:

  • Use an accessor with a function-local static (lazy, initialization-order safe, and since C++11 the init is thread-safe):

    static std::list<Node>& nodes() {
    static std::list<Node> instance;
    return instance;
}

  • Or, if you can use C++17+, define the member in-class as an inline static to keep a single definition in the header:

    class NodeManager {
public:
    inline static std::list<Node> node_list; // C++17+
};

Best practices: keep the container private and provide controlled accessors, prefer dependency injection over global mutable state, and pick the right container (std::vector is often faster than std::list). For , the short answer is: your header declaration was fine — just provide one definition or use one of the patterns above for a cleaner, safer design.

Recommended Answers

All 4 Replies

Member Avatar for Ancient Dragon

static class objects also have to be declared globally in a *.cpp file

// Node.cpp
#include "Nodes.h"

#include <list>

// declare the static object globally
std::list<Node> NodeManager::node_list;

void generateNodes() {
	Node n1(1, 346.0, 26.5, -470.0);
	n1.children.push_back(2);
	n1.children.push_back(4);
	n1.children.push_back(5);
	NodeManager::node_list.push_back(n1);

	// defining more nodes
}
Edited by Ancient Dragon because: n/a
Member Avatar for SoulMazer

Wow, thanks for the quick reply. And thanks, that got rid of my errors.

However, is it okay to declare a global list like that if many other files are going to be #include'ing Node.h? Wouldn't that reset its value? That's the reason I was originally trying to do a static list.

Member Avatar for Ancient Dragon

You declare it globally in one, and only one *.cpp file. Other *.cpp files that use that header do not have to do that.

Member Avatar for SoulMazer

Gotcha. Okay, thanks. That definitely solves my problem.

Thanks again.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.