Member Avatar for noxee

I'm trying to read from a text file multiple times but I only seem to be able to read the data once. Any advice would be greatly appreciated.

string input;
    
    while (!ifile.eof())
    {
        getline(ifile,input);
        cout << input << endl;
    }
    
    while (!ifile.eof())
    {
        ifile.get(ch);
        cout << ch;
    }
  • 4 Contributors
  • 4 Replies
  • 312 Views
  • 2 Years Discussion Span
  • Latest Post Latest Post by Member #399894

Dani AI

Generated

Brief diagnosis and practical guidance (builds on ’s hint and ’s note about eof()):

When a stream reaches the end, the stream sets eofbit (and often failbit). Further extraction calls immediately fail until the error state is cleared or the stream is reopened. That’s why the second loop in the original post produced no output even though the file still contains data.

Prefer testing the read operation itself rather than polling eof(). Example patterns:

std::string line;
while (std::getline(file, line))           // stops on failure or EOF
    std::cout << line << '\n';

char ch;
while (file.get(ch))                       // reads every character robustly
    std::cout << ch;

To read the same file a second time there are two simple, reliable choices:

  • Close and reopen the stream (easy and foolproof).
  • Reset flags and reposition the read pointer (clear the error state, then seek to the beginning).

Always verify the file opened successfully before reading:

std::ifstream in(path);
if (!in) { std::cerr << "failed to open\n"; /* handle error */ }

Additional tips and gotchas (relevant to ’s examples):

  • Either let each helper open its own ifstream (RAII), or open once in main and pass a reference—but don’t call open() on a stream that’s already open without closing it first.
  • Avoid using while(!stream.eof()) — it commonly produces duplicate or partial reads.
  • For counting bytes or doing fast raw reads, consider istreambuf_iterator or read()/readsome rather than formatted extraction.

This complements the thread: ’s symptom is the classic EOF/flag issue; ’s reset approach is correct, and the loop-style shown above is a more robust way to drive reads.

Recommended Answers

All 4 Replies

Member Avatar for GloriousEremite 
string input;
 
    while (!ifile.eof())
    {
        getline(ifile,input);
        cout << input << endl;
    }

    ifile.seekg(0,std::ios::beg); //reset read pos to beginning
    ifile.clear(); //clear eofbit

    while (!ifile.eof())
    {
        ifile.get(ch);
        cout << ch;
    }
Member Avatar for noxee

Thanks for the help. I had tried repositioning the buffer but I didn't reset the eof bit. Thanks again

Member Avatar for Member #399894

omg thank you so much, this helped me a lot!! thank you!!! ;D

noxee maybe you did something else wrong? well this is my code and the program works! it's nothing special, just a simple code....

#include <iostream>
#include <fstream>
using namespace std;

void characters (ifstream &entrance)
{
	entrance.open ("bla2.txt");
	char a;
	int counter=0;
	entrance>>a;
	while (!entrance.eof())
	{	
		cout<<a<<" ";
		counter++;
		entrance>>a;
	}
	cout<<endl;
	cout<<"There is "<<counter<<" characters in the file"<<endl;
	entrance.close();
}

void words (ifstream &entrance)
{
	entrance.open ("bla2.txt");
	char a[20];
	int counter=0;

	while (!entrance.eof())
	{
		entrance>>a;
		cout<<a<<endl;
		counter++;
	}

	cout<<"There is "<<counter<<" words in the file"<<endl;
	entrance.close();
}

void rows (ifstream &entrance)
{
	entrance.open ("bla2.txt");
	
	char a[100];
	int counter=0;
	while (!entrance.eof())
	{
		entrance.getline (a, sizeof(a));
		counter++;
		cout<<a<<endl;
	}

	cout<<"There is "<<counter<<" rows in the file"<<endl;
	entrance.close();
}

int main () {

	ifstream entrance;
	
	characters (entrance);
	cout<<endl;
	
	entrance.seekg(0,std::ios::beg);
            entrance.clear();
	words (entrance);
	cout<<endl;
	
	entrance.seekg(0,std::ios::beg);
            entrance.clear();
	rows (entrance);
	cout<<endl;

	return 0;
}
commented: two years too late. -7
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.