Y.a.n.q

[rodkay]

Folks,
Most of you can see what the below segment of code is doing, the problem I have is that the program is skipping the next line in the source file (airportsMaster) after it has processed a successful match.

Is the problem because I am using getline twice or that my ignore length is wrong?

while ( !airportsMaster.eof())
    {
        airportsMaster.getline(icaoChr, 5,',');
        for ( int i=0; i<(numAirports); i++ )
        {
            if (icaoChr == icaoStr[i])
            {
                airportsList << icaoStr[i] << ",";
                airportsMaster.getline(tempChr, 35,'\n');
                airportsList << tempChr << "\n";
            }
        }
        airportsMaster.ignore(35, '\n');
    }

The source file (a simple .txt file) contains 26000+ lines in format like below ...

SKTM,N6* 27.18',W71* 45.69',1050
SKTQ,N0* 43.60',W75* 12.92',597
SKTU,N8* 3.98',W76* 44.88',7
SKUA,N5* 28.41',W68* 41.13',285

as you can see the length varies between 29-34 char.

[John A]

Think of it this way:

This fills tempChr with data up until a newline is reached, however it also trashes the newline that follows.

airportsMaster.getline(tempChr, 35,'\n');

Now this trashes another whole line (or 35 chars, whatever comes first):

airportsMaster.ignore(35, '\n');

So of course it's going to skip some lines.

[thekashyap]

while ( !airportsMaster.eof())
{
    airportsMaster.getline(icaoChr, 5,',');
    for ( int i=0; i<(numAirports); i++ )
    {
        if (icaoChr == icaoStr[i])
        {
        airportsList << icaoStr[i] << ",";
        airportsMaster.getline(tempChr, 35,'\n');
        airportsList << tempChr << "\n";
        }
    }
    airportsMaster.ignore(35, '\n');
}

You have already extracted teh '\n' on line 10. It really isn't THAT obvious what the code is doing, but my guess is that line 13 should be in an else of the if inside for loop.

[rodkay]

Think of it this way:

This fills tempChr with data up until a newline is reached, however it also trashes the newline that follows.

airportsMaster.getline(tempChr, 35,'\n');

Now this trashes another whole line (or 35 chars, whatever comes first):

airportsMaster.ignore(35, '\n');

So of course it's going to skip some lines.

Joe,
Because my source lines are variable lenght I don't know what else to use as a terminting character? Are you suggesting i find lenght of the line and then just getline the characters I need?
The reason I have the ignore statement is to advance my source file to the next line, is there another way of doing this without flushing out the istream buffer? (in my eronous case a second time)

Rod

[John A]

You flush the line when you use that second getline() statement. Using ignore() flushes it again, skipping a line.

So... do what kashyap suggested. Create an else statement, so that ignore() only executes when the stream hasn't already been cleared.

[rodkay]

Joe & thekashyap - thanks so much for your help.

To be honest I missed the 'else' suggestion; in the meantime in an effort to figure out how to step through the source file without using ignore I decided to take a completely different approach which works, and is tighter code ...

while ( !airportsMaster.eof())
    {
        airportsMaster.getline(tempChr, 35,'\n');
        tempStr = tempChr;
        for ( int i=0; i<(numAirports-1); i++ )
        {
            found=tempStr.find(icaoStr[i]);
            if (found!=string::npos)
            {
                airportsList << tempChr << "\n";
            }
        }
    }

I am going to go now and read up on and play with various stream handling fundamentals. Thanks again for your help.