Factorial program using recursion Python

[vishwas_1]

Hii ,I was making a factorial program in python using recursion/ but I have one doubt : if I run the program I get the error as : " result=xfact(x-1) TypeError: unsupported operand type(s) for : 'int' and 'NoneType'"
But If I run it with the commented statements it works fine .So my question is in the else why my return statent doesn't work ?

def fact(x):
    if x==1 or x==0:
        y=1
    else:
        #result=x*fact(x-1)
        #return result
        y=x*fact(x-1)
    return y

t=int(input())
for i in range(t):
    n=int(input())
    y=fact(n)  
    print(y)

[rproffitt]

I can't guess if that's all the code. But one thought here is to debug it with examining the type() of that variable result.
https://docs.python.org/2/library/functions.html?highlight=type#type if you don't know the function.

[tinstaafl]

When I try both sets of code with Python 3.4 in VS 2015 they seem to work without errors. Of course that's assuming that when you tried using the result variable you also changed all the instances of the y variable to result.

[hussainmujtaba]

Here is the code to find the factorial of a python using recursion.This code works fine :

def recur_factorial(n):
    """Function to return the factorial
    of a number using recursion"""
    if n == 1:
        return n
    else:
        return n*recur_factorial(n-1)

num=int(input("Enter the number: "))

print("factorial of ",num," (recursive): ",end="")
print(recur_factorial(num))

There are other ways to find factorial too such as iteration, or using a function, or for best performance use dynnamic programming.Here is a detailed article about all these methods: Factorial in Python

[Reverend Jim]

A more concise (and still clear) version of that would be

def fac(n):
    return 1 if n <= 1 else n * fac(n-1)