Member Avatar for dannynez

i get this Warning: Cannot modify header information - headers already sent by (output started at c:\appserv\www\conectarse.php:2) in c:\appserv\www\conectarse.php on line 61

and this warning happen in line 58 - header("Location: ".$MM_redirectLoginSuccess);
and in line 61 - header("Location: ".$MM_redirectLoginFailed);

pls i need somebody help me to resolve this

this is my code:

<?php session_start(); ?>
<?php virtual('/Connections/conexion.php');?>
<?php if (!function_exists("GetSQLValueString")) { function GetSQLValueString($theValue, $theType, $theDefinedValue ="", $theNotDefinedValue =""){
  $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);
  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    
    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}
?>
<?php
// *** Validate request to login to this site.
if (!isset($_SESSION)) {
  session_start();
   }
$loginFormAction = $_SERVER['PHP_SELF'];
if (isset($_GET['accesscheck'])) {
  $_SESSION['PrevUrl'] = $_GET['accesscheck'];
}
if (isset($_POST['login'])) {
  $loginUsername=$_POST['login'];
  $password=$_POST['password'];
  $MM_fldUserAuthorization = "";
  $MM_redirectLoginSuccess = "/zonaprivada.php";
  $MM_redirectLoginFailed = "/existe.php";
  $MM_redirecttoReferrer = false;
  mysql_select_db($database_conexion, $conexion);
  $LoginRS__query=sprintf("SELECT login, password FROM usuarios WHERE login=%s AND password=%s",
    GetSQLValueString($loginUsername, "text"), GetSQLValueString($password, "text")); 
  $LoginRS = mysql_query($LoginRS__query, $conexion) or die(mysql_error());
  $loginFoundUser = mysql_num_rows($LoginRS);
  if ($loginFoundUser) {
     $loginStrGroup = "";
    //declare two session variables and assign them
    $_SESSION['MM_Username'] = $loginUsername;
    $_SESSION['MM_UserGroup'] = $loginStrGroup;	      
   
  if (isset($_SESSION['PrevUrl']) && false) {
      $MM_redirectLoginSuccess = $_SESSION['PrevUrl'];	
    } 
    header("Location: ".$MM_redirectLoginSuccess);
	}
  else {
    header("Location: ".$MM_redirectLoginFailed);
	}
}
?>
<html>
<head>
<title>Documento sin t&iacute;tulo</title>
</head>
<body>
<form name="form1" method="POST" action="<?php echo $loginFormAction; ?>">
  <label>Login
  <input type="text" name="login" id="login">
  </label>
  <p>
    <label>Contraseña
    <input type="text" name="password" id="password">
    </label>
  </p>
  <p>
    <label>
    <input type="submit" name="conectar" id="conectar" value="Conectar">
    </label>
  </p>
</form>
</body>
</html>
Edited by Ezzaral because: Added code tags. Please use them to format any code that you post.
  • 5 Contributors
  • 5 Replies
  • 128 Views
  • 2 Days Discussion Span
  • Latest Post Latest Post by pzuurveen
Member Avatar for xandro

Hi, dannynez

These kind of errors appear when you use the header function and has already been sending some kind of output to the browser for example this will not work:

echo ' ';
header('Location: index.php');

The problem is that any kind of output used before the header function will cause this kinds of problems.

You could for example try not splitting the PHP code into serveral blocks as you do on line 1, 2, 3, 27 and 28, try to use one complete block.

Best regards
// Xandro

Member Avatar for chintan@dani

Or even this error may occure if you are using white-space before <?php & after ?>.
Look for any statements that could send output to the user before this header statement. If you find one or more, find some way to move the header statement before them.

Member Avatar for dddougal

You can actually put the headers wherever you want.

Put ob_start() at the top of your page and then ob_end_flush() after your header()

Member Avatar for xandro

To dddougal:

Yes this is a way to solve the problem, but it feels a little like going around the problem instead of writing good-practiced code.

Member Avatar for pzuurveen 
virtual('/Connections/conexion.php');

alsso sent the headers
can't you use include or require ?

Edited by pzuurveen because: n/a
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.