Member Avatar for ddanielsmith

Here's my index.php page:

<?php
require 'connect.php';
?>

<html>
<body>

<form action="action.php" method="post">
Username: <input type="text" name="uname">

Password: <input type="password" name="pword">
<input type="submit" name="submit1" />
</form>

</body>
</html>

Here's my connect.php page:

<?php
$connect = mysql_connect("localhost", "root", "");
if (!$connect)
{
die ('Could not connect: ' . mysql_error ());
}

mysql_select_db("users", $connect);
?>

Here's my action.php page:

</php

require 'connect.php';

$username = $_POST ['uname'];
$password = $_POST ['pword'];

mysql_query("INSERT INTO userlogin ($username, $password)
VALUES ('$username', '$password')");

?>

Here's the problem:

Every time I try to register a username and password into the table in my database, It doesn't work.
Nothing happens. I'm trying to register a username and password into my table userlogin, but nothing happens!

Please help! I'll choose a best answer.

  • 3 Contributors
  • 2 Replies
  • 131 Views
  • 45 Minutes Discussion Span
  • Latest Post Latest Post by klemme
Member Avatar for GliderPilot

Your action.php opening PHP tag is </php rather than <?php

Member Avatar for klemme

Like GliderPilot said: You are using </php in your action.php page. Change it to <?php..
I have created the script for you at the bottom of the page, but maybe the lines in between can help you understand it better :-)

mysql_query("INSERT INTO userlogin ($username, $password)
VALUES ('$username', '$password')");

You are trying to insert into variable names. Isnt that supposed to be:

mysql_query("INSERT INTO userlogin (username, password)
VALUES ('$username', '$password')");
// Without $ for your columns

Also it is a good idea to escape your data:

$username = mysqli_real_escape_string($connect, $_POST['uname']);
// Tjeck up on how the syntax is when you dont use mysqli extension.

You have spaces between here, maybe that also creates some error:

$_POST ['uname']
// Try:
$_POST['uname']

Does this help?

// EDIT EDIT FOR ACTION PAGE:

If(isset($_POST['submit1'])) {
   $username = mysqli_real_escape_string($connect, $_POST['uname']);
   $password = mysqli_real_escape_string($connect, $_POST['pword']);

   if(mysqli_query($connect, INSERT INTO userlogin (username, password) VALUES ('".$username."', '".$password."'))) {
       echo 'User has been created';
   } else die(mysqli_error($connect));
}

Should work?

/Klemme

Edited by klemme
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.