q is undefined - php javascript

Question

xbat -4 Junior Poster in Training

12 Years Ago

Getting a q is undefined.. I took <option="1">1</option> etc.. and now I'm pulling with ajax from datasrc..

I can't quite figure out how to define my database value.. The one uses query which pulls from the auto start typing.. then it submits to the other page through q - Once you click the item box where the part number is taken from.. It does not send q through.. Any pointers or help would greatly be appericated.

<script>

function showUser(str)
{
if (str=="")
  {
  document.getElementById("txtHint").innerHTML="";
  return;
  }
if (window.XMLHttpRequest)
  {// code for IE7+, Firefox, Chrome, Opera, Safari
  xmlhttp=new XMLHttpRequest();
  }
else
  {// code for IE6, IE5
  xmlhttp=new ActiveXObject("Microsoft.XMLHTTP");
  }
xmlhttp.onreadystatechange=function()
  {
  if (xmlhttp.readyState==4 && xmlhttp.status==200)
    {
    document.getElementById("txtHint").innerHTML=xmlhttp.responseText;
    }
  }
xmlhttp.open("GET","testtwopart1.php?q="+str,true);
xmlhttp.send();
}
</script>


</head>
<body>

<form name="invoice1">
<select name="users" onchange="showUser(this.form)" width="80" style="width:80px" class="autoconvert contain" datasrc="inventory.php">

</select>


<div id="txtHint"><b>billing will be listed here.</b></div>

javascript php

5 Contributors
21 Replies
424 Views
5 Days Discussion Span
Latest Post 12 Years Ago Latest Post by xbat

urtrivedi 276 Nearly a Posting Virtuoso

12 Years Ago

where is code for testtwopart1.php, post it here

veedeoo 474 Junior Poster

12 Years Ago

Hi,

Try adding...

if(isset($_GET['q'])){

## codes for the script response when GET is triggered
$q=$_GET["q"];
}

else{

$q = '';

}

Alternatively, I keep on seeing this type of approach by other developers of which I have not tested or ever tried, but I think it is worth teting for any vulnerability issues and weaknesses..

 if($_GET){

 ## codes here

 }
 else{

 $q = '';

 }

Again the alternative option is just too broad for my consideration. I am just assuming here that this method can fail.

Edited 12 Years Ago by veedeoo because: more info. added

urtrivedi 276 Nearly a Posting Virtuoso

12 Years Ago

Pass this.value not this.form to showuser (line 35 in your code above in post 1)

<select name="users" onchange="showUser(this.value)" width="80" style="width:80px" class="autoconvert contain" datasrc="inventory.php">

adam.adamski.96155 43 Junior Poster

12 Years Ago

@xbat, from what I can see, 'q' is not defined in your JS code, it is not even referenced, so it can't be JS that's giving the error. The only way I can understand this undefined error regarding 'q' is the processing page, testwopart1.php.
The beginning of the script (testwopart1.php), references $_GET['q'] and if this variable is not defined, you will get an error of type notice concerning an 'undefined key'. Veedeeo's suggestion to use a test: if(isset($_GET['q'])) is the way to avoid this error. If you want to test testwopart1.php, you can go directly to the page and add "?q=something" into the address bar (change the something to what you think should be sent) and see what the output is. If the output looks good, then I would put a line at the top of testwopart1.php: echo "some random words"; die(); and then alert the xmlhttp.responseText to the screen on return to the ajax function. From these two steps you can get a better idea of where the problem lies.
I find this type of problem standard issue whenever I have used Ajax. Good luck :)

adam.adamski.96155 43 Junior Poster

12 Years Ago

It's this line:
xmlhttp.open("GET","testtwopart1.php?q="+str,true);
str is undefined.
utrivedi suggested changing line 35:
<select name="users" onchange="showUser(this.value)"
I agree with him.

You could alert the value of str before you send the ajax request, to make sure it is formed properly.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

xbat -4 Junior Poster in Training Banned · Answer 1 · 2012-11-08T17:07:23+00:00

Sorry... heres the testwopart1.php

`<?php
$q=$_GET["q"];

$con = mysql_connect('localhost', 'yaaaaaaaa', 'passomass');
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("something", $con);

$sql="SELECT * FROM inventoryjazz WHERE itemnumber = '".$q."'";

$result = mysql_query($sql);

echo "<table>

<input type='text' name='inp1' value='desci={}'> ";

while($row = mysql_fetch_array($result))
  {
  echo "<tr>";
  echo "<td>" . $row['itemnumber'] . "</td>";
  echo "<td>" . $row['description'] . "</td>";
  echo "<td>" . $row['list'] . "</td>";
  echo "</tr>";
  }
echo "</table>";




mysql_close($con);
?> `

xbat -4 Junior Poster in Training Banned · Answer 2 · 2012-11-08T18:03:50+00:00

Hello,

Sorry no I didn't get it to work... Its with firebug and i believe the java that is causing the error.

I believe the javascript still thinks its pulling from <option="value <<<< and im trying to get it to pull from q thats where its causing an error i believe

xbat -4 Junior Poster in Training Banned · Answer 3 · 2012-11-08T18:27:05+00:00

I changed the this.value, as for if(isset($_GET['q'])) and veedeoo I tried that and am I still getting the same error

xbat -4 Junior Poster in Training Banned · Answer 4 · 2012-11-08T20:01:04+00:00

Heres the error I am getting with firebug.. It works fine on query but doesn't work with q Click Here

query1

xbat -4 Junior Poster in Training Banned · Answer 5 · 2012-11-08T20:14:36+00:00

eve after changing this.form to this.value I still get the same error.. with q

adam.adamski.96155 43 Junior Poster · Answer 6 · 2012-11-08T20:43:35+00:00

Can you copy the structure of the select list from the source when the page has loaded and post a few lines here?

xbat -4 Junior Poster in Training Banned · Answer 7 · 2012-11-08T20:50:48+00:00

I'm not sure what your asking me.. Do I go into firebug and do this? What do I click?

adam.adamski.96155 43 Junior Poster · Answer 8 · 2012-11-08T21:26:16+00:00

<option="1">1</option>
I need to see this part.
You can view source when the page has loaded and copy/paste here.

xbat -4 Junior Poster in Training Banned · Answer 9 · 2012-11-08T23:39:35+00:00

There is no <option="1">1</option>... .. I took <option="1">1</option> etc.. and now I'm pulling with ajax from datasrc.. I'm trying to pull from the datasrc not option 1

adam.adamski.96155 43 Junior Poster · Answer 10 · 2012-11-09T09:54:08+00:00

If I could see how the options are formed, I could be certain how to proceed, but without seeing I can still make a guess.

change your select declaration to this:
<select name="users" onchange="showUser(this)"

...then add this line:
q_str = str.options[str.selectedIndex].value;
...above the line:
xmlhttp.open("GET","testtwopart1.php?q="+q_str,true);
notice that 'str' was changed to 'q_str' in the line above.

There is a special way of finding out which option was selected and your script wasn't configured to discover it. showUser(this) passes the element itself to the function (this element) and str.options[str.selectedIndex].value gets the value of the selected option. Theoretically, you could send the selected option straight to the function but it would get messy in those parenthesis:
showUser(this.options[this.selectedIndex].value)

If it doesn't work now, I need to see the structure of the select element, specifically the options... yes I know they are pulled from the src file, but they must still exist in the page when it is loaded or there could be no 'onchange' taking place. Right-click and view source to see them.
Good luck :)

xbat -4 Junior Poster in Training Banned · Answer 11 · 2012-11-09T15:03:08+00:00

What code where you looking for or needing?

I'm getting this error - TypeError: str.selectedIndex is undefined

Thanks for all your help with all this.. I have forgotten alot with javascript.

adam.adamski.96155 43 Junior Poster · Answer 12 · 2012-11-09T16:15:01+00:00

I will show you what I mean:

A standard select menu...

<select id="select" onchange="alertSelected(this)">
    <option value="1">One</option>
    <option value="2">Two</option>
    <option value="3">Three</option>
    <option value="4">Four</option>
    <option value="5">Five</option>
</select>

...will have the select declaration:
<select id="select">
...and will also have some options:

<option value="1">One</option>
<option value="2">Two</option>

Without the options we can't 'select' one and send that selection in the ajax request.
As an example, we will only alert the selected value using a JS function:

function alertSelected(el){
    var selected = el.options[el.selectedIndex].value; 
    alert(selected);
}

I am running this exact code in my browser and it is alerting the selected value when I choose an option. We need to do the same with your code, which means seeing the structure of the '<option>'s. The way to acheive this is to let the page load, then view the source of the page (standard procedure), then look through the source for the section where the options are set.
You can copy that code and paste it here (hopefully) :)

xbat -4 Junior Poster in Training Banned · Answer 13 · 2012-11-09T16:25:33+00:00

I'm not using any otptions. I'm pulling directly for the database.

example of what im using -

`<select name="users" onchange="showUser(this)" width="80" style="width:80px" class="autoconvert contain" datasrc="inventory.php">

</select> `

I'm not using

</select>

adam.adamski.96155_1 0 Newbie Poster · Answer 14 · 2012-11-09T17:42:25+00:00

I never used 'datasrc=""' before, I have searched and found this page:
http://msdn.microsoft.com/en-us/library/ms531385(v=vs.85).aspx7
In the example of a select element bound to a datasrc you can still view the options in the source of the page.
q will remain undefined until you can get the selected option.
Can I see the page?

xbat -4 Junior Poster in Training Banned · Answer 15 · 2012-11-10T18:04:29+00:00

xbat -4 Junior Poster in Training

12 Years Ago

what code or page did you want to see?

xbat -4 Junior Poster in Training Banned · Answer 16 · 2012-11-14T11:35:34+00:00

I found a different way of doing this with jquery... I am going to mark this solved.