Member Avatar for lewashby

In the following code blocks I don't see any affect that my java scipt is having on my form. Any ideas? Thanks.

Form:

    if($row['password'] == $passwd)
    {
    echo "<html>";
    echo "<body>";
    echo "<script src='check.js'></script>";
    echo "<form id='form1' action='changepassword.php' method='post'>";
    echo "<table>";
    echo "<tr><td>";
    echo "New Password<center><input type='text' name='newpassword1'></td></tr></center>";
    echo "<tr><td>";
    echo "Re-Enter Password<center><input type='text' name='newpassword2'></td></tr></center>";
    echo "<tr><td><input type='submit' value='submit' onclick='return validate(this.form,6,8)'></td></tr>";
    echo "</table>";
    echo "</form>";
    echo "</body>";
    echo "</html>";
    }

Script:

function validate(form, minlength, maxlength) 
{
    var userInput = form.elements[0].value

if(userInput.length >= minlength && userInput.length <= maxlength)
{
    return true;
}
else
{
    alert("Please input between " + minlength + " and " + maxlength + " characters");
    return false;
}
  • 3 Contributors
  • 6 Replies
  • 266 Views
  • 1 Day Discussion Span
  • Latest Post Latest Post by lewashby
Member Avatar for JorgeM

If you look at your javascript, you are missig a closing brace "}" at the end. When I copy your code and run it, it works fine.

Keep in mind that with your script, you are only checking the first input element. You'd have to modify this to ensure that both input elements are filled out and you have to make sure that the user typed in the same information in both input fields.

Here is a working demo of your code. http://itg.somee.com/dw/dw-465310/

Edited by JorgeM
Member Avatar for lewashby

I did make sure that both fields were the same but I did that part with php. Thanks, I'll give this another try.

Member Avatar for lewashby

I took a second look, I don't see any missing "}".

Member Avatar for urtrivedi 
function validate(form, minlength, maxlength) 
{
    var userInput = form.elements[0].value

    if(userInput.length >= minlength && userInput.length <= maxlength)
    {
        return true;
    }
    else
    {
        alert("Please input between " + minlength + " and " + maxlength + " characters");
        return false;
    }
} <-- this is missing
Member Avatar for lewashby

I see that I didn't past it here on daniweb but the last "}" is in my script and it still isn't doing anything.

Member Avatar for lewashby

Working! thanks all.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.