Member Avatar for naazer.hussain

I am getting this "Notice: Undefined index: id" error message for my login system. I have tried several things to fix this but i have had no luck, i have used the most obvious solution, the isset function but i have had no luck. Please help.

This is the error message... Notice: Undefined index: id in /Applications/MAMP/htdocs/project/functions.php on line 6. The code for the functions page is below, if i need to include other pages please let me know.

Thanks in advance

<?php



function is_logged_in(){
    if($_SESSION['id'] or $_COOKIE['id']){
        if($_COOKIE['id'] and !$_SESSION['id']) $_SESSION['id'] = $_COOKIE['id'];
        return $_SESSION['id'];
    }
    else
        return false;
}
function redirect_if_logged_in(){
    if(is_logged_in()){
        echo 'You are logged in. Redirecting!!';
        redirect2home();
    }
}
function redirect_if_not_logged_in(){
    if(!is_logged_in()){
        echo 'You are not logged in. Redirecting!!';
        redirect2home();
    }
}

function redirect2home(){
    die('<META HTTP-EQUIV="refresh" CONTENT="5; URL=personal.php">');
}

?>
  • 5 Contributors
  • 4 Replies
  • 821 Views
  • 1 Week Discussion Span
  • Latest Post Latest Post by bugz313

Dani AI

Generated

The notice comes from accessing an array key that doesn't exist: the posted functions.php checks $_SESSION['id']/$_COOKIE['id'] directly, which triggers PHP's "Undefined index" notice when the key is missing. The suggestions from and to start the session early, and 's point about checking existence, are the right directions — the practical fix is to ensure a session is started before any access and to test for existence/validity before using those superglobals.

Practical checklist and a safe pattern to follow:

  • Make sure session_start() runs before any output and before including functions.php. If functions.php is used site-wide, start the session once at the top of the request (or conditionally use session_status()/session_id() to avoid duplicate starts).
  • Never read $_SESSION['id'] or $_COOKIE['id'] without checking; use isset()/empty() or validate the cookie value before trusting it.
  • If a cookie is used to repopulate the session, validate and sanitize that value (numeric ID, token lookup, etc.) before assigning it to $_SESSION.

Example (robust, avoids undefined-index notices):

<?php
if (function_exists('session_status') && session_status() !== PHP_SESSION_ACTIVE) {
    session_start();
}

function is_logged_in() {
    if (!empty($_SESSION['id'])) {
        return (int) $_SESSION['id'];
    }

    $cookieId = filter_input(INPUT_COOKIE, 'id', FILTER_VALIDATE_INT);
    if ($cookieId !== null && $cookieId !== false) {
        $_SESSION['id'] = $cookieId; // validate against DB if needed
        return $cookieId;
    }

    return false;
}

Additional notes: using or has lower precedence than || and can cause surprising behavior in complex expressions, so prefer || or explicit parentheses. For production, fix the root cause rather than hiding notices; disable display of errors (display_errors = Off) but keep logging enabled. Simple debug steps: var_dump($_SESSION) early in the script, confirm both include order and that session_start() executes before any HTML output (this is what asked about).

Recommended Answers

All 4 Replies

Member Avatar for ehpratah

Is your session ID set? try echoing for the value first if your really getting it.your file should start with a session_start() function for your session variable to work try adding it at line 2

Member Avatar for OsaMasw

try to use isset(), to check if there is a value assign to $_SESSION

 if(isset($_SESSION['id']) or isset($_COOKIE['id'])){
 // do whatever you want
 }
Member Avatar for Gideon_1

can i say, have you set the session.

Member Avatar for bugz313

where do you have your start_session() function?? it has to be the first thing you do before anything else, so before you are including this php in any file.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.