Directory Listing

Question

yongj 1 Junior Poster in Training

15 Years Ago

So I'm trying to code a program where it produces a directory listing of all files matching a specified file name pattern. I have compiled a code that is somewhat similar (But still functions differently) than the code I want; my code just lists the directory with full parameters. How can I make it from here so that it can list only the directory list that matches a specified file name pattern. So for example, how can I code it so that if I type myDir *.c it would list all files with an extension ".c" in that current directory?

This brings me to my second question: how can I make it so that my solution file "myDir.c" can be ran from the command prompt? Navigating to my solution file in CMD and entering "myDir bla" doesn't do anything when it should print the current directory with full pathnames on CMD. Please help!!

Here's my code:

#include <windows.h>
#include <winbase.h>
#include <stdio.h>
#include <string.h>

int main(int argc, char *argv[]) 
{
	WIN32_FIND_DATA  found;     // Search buffer 
	HANDLE           hFind;     // Search handle 
	char             path[MAX_PATH]; 
	char             fname[MAX_PATH]; 
	GetCurrentDirectory(MAX_PATH, path); 
	hFind = FindFirstFile("*.*", &found); 
   
	if(hFind != INVALID_HANDLE_VALUE) { // Found a first file 
	    do { 
	      if( (strcmp(found.cFileName, ".")  != 0) && 
	       (strcmp(found.cFileName, "..") != 0) ) 
		  { 
			// Construct Fully-qualified File Specification 
			strcpy_s(fname, MAX_PATH, path);  
			strcat_s(fname, MAX_PATH, "\\"); 
			strcat_s(fname, MAX_PATH, found.cFileName); 
         
			printf("%s\n", fname); 
		  } 
		} while(FindNextFile(hFind, &found));

		FindClose(hFind); 
	}

	return(0);
}

c

4 Contributors
15 Replies
210 Views
1 Day Discussion Span
Latest Post 15 Years Ago Latest Post by Ancient Dragon

Dani AI

Generated 7 Months Ago

Short version: the program must accept the mask from the command line (argv) and pass that exact string to FindFirstFile; and you must compile the .c into an .exe and run that .exe from the folder (or put it on PATH). was right to point you at command-line parameters, and was right that the string you give FindFirstFile must include the wildcard (for example "C:\MyDir*.c" or simply "*.c").

Check the program and arguments quickly

Paste and compile this tiny tester to verify your program actually runs and receives arguments (this helps isolate “not a command” vs. “arguments aren’t coming through”):

#include <stdio.h>

int main(int argc, char *argv[])
{
    for (int i = 0; i < argc; ++i)
        printf("argv[%d] = %s\n", i, argv[i]);
    return 0;
}

Compile and run

In Visual Studio: add the .c to a Win32 Console project and Build; the EXE is usually in the project’s Debug\ or Release\ folder.
From the Developer Command Prompt you can run: cl myDir.c (produces myDir.exe). With MinGW: gcc -o myDir.exe myDir.c.
At the prompt type only the command and arguments — do NOT type the leading prompt characters. Example: myDir *.c or myDir C:\some\path\*.c. If you get “is not recognized”, you are not in the folder with myDir.exe (or it wasn’t built), so cd into the folder or give the full path.

Integration tip for your program

If argc == 1 use "*.*"; if argc == 2 treat argv[1] as either a mask or a full path-with-mask; if you accept a directory and mask separately, safely combine them (ensure a backslash between directory and mask) before calling FindFirstFile.
Note: cmd.exe does not expand wildcards for programs (the program gets the literal *.c); PowerShell can expand them, so quote the mask there (for example .\myDir.exe '*.c').

Troubleshooting checklist

Confirm myDir.exe exists (dir myDir.*).
If using Visual Studio, check Project → Properties → Output Directory.
Use the argv tester above to confirm arguments arrive.

All 15 Replies

WaltP 2,905 Posting Sage w/ dash of thyme

15 Years Ago

How can I make it from here so that it can list only the directory list that matches a specified file name pattern. So for example, how can I code it so that if I type myDir *.c it would list all files with an extension ".c" in that current directory?

How do you make it list all the files? Figure that out and change it.

This brings me to my second question: how can I make it so that my solution file "myDir.c" can be ran from the command prompt? Navigating to my solution file in CMD and entering "myDir bla" doesn't do anything when it should print the current directory with full pathnames on CMD.

You need to use the command line parameters. See this series -- it may help.

Ancient Dragon 5,243 Achieved Level 70

15 Years Ago

The parameter to FindFirstFile() is wrong. If you want to find all the files in c:\\MyDir *.c then use that as the parameter to FindFirstFile.

Note: The code below has not been compiled or tested. This is supposed to concantinate all the command-line parameters to make a single path statement. For example, if you type on the command line myprog c:\MyDir <space> *.c then it should result in "c:\MyDir\*.c"

int main(int argc, char* argv[])
{
   char path[_MAX_PATH] = {0};
   int i;
   for(i = 1; i < argc; i++)
   {
      strcat(path,argv[i]);
      if( i < argc)
        strcat(path,"\\");
   }
   find = FindFirstFile(path,&found);
}

WaltP 2,905 Posting Sage w/ dash of thyme

15 Years Ago

Okay, thanks! But I'm still having trouble running my program from command line. How can I make it so that I can simply type "myDir blah.ext" from the cmd for it to print the directory ON the cmd window itself?
Thanks.

I'm now sorry I bothered to post. :icon_confused:

Edited 15 Years Ago by WaltP because: n/a

WaltP 2,905 Posting Sage w/ dash of thyme

15 Years Ago

CMD keeps giving me the same prompt: "myDir is not a command" or something along those lines.

Ahhh, info that actually tells us something about your problem. Either:
1) There are compile errors therefore myDir was never built.
2) You are not in the directory where myDir.exe exists when you type the command.

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

yongj 1 Junior Poster in Training · Answer 1 · 2011-04-26T22:01:20+00:00

The parameter to FindFirstFile() is wrong. If you want to find all the files in c:\\MyDir *.c then use that as the parameter to FindFirstFile.
Note: The code below has not been compiled or tested. This is supposed to concantinate all the command-line parameters to make a single path statement. For example, if you type on the command line myprog c:\MyDir <space> *.c then it should result in "c:\MyDir\*.c"
int main(int argc, char* argv[])
{
   char path[_MAX_PATH] = {0};
   int i;
   for(i = 1; i < argc; i++)
   {
      strcat(path,argv[i]);
      if( i < argc)
        strcat(path,"\\");
   }
   find = FindFirstFile(path,&found);
}

Okay, thanks! But I'm still having trouble running my program from command line. How can I make it so that I can simply type "myDir blah.ext" from the cmd for it to print the directory ON the cmd window itself?

Thanks.

yongj 1 Junior Poster in Training · Answer 2 · 2011-04-27T00:25:22+00:00

I'm now sorry I bothered to post. :icon_confused:

Oh, no I didn't ask that question because I ignored your post. I asked the question again because I tried that already but it didn't work. CMD keeps giving me the same prompt: "myDir is not a command" or something along those lines.

Sorry, I wasn't trying to be rude. I appreciated your effort! :)

yongj 1 Junior Poster in Training · Answer 3 · 2011-04-27T01:01:07+00:00

By the way, is the ">" necessary to execute the program? So for instance, would I need to type "C:\Users\Documents\>myDir blah" to execute the program myDir with the single argument "blah" ?

yongj 1 Junior Poster in Training · Answer 4 · 2011-04-27T07:51:03+00:00

Ahhh, info that actually tells us something about your problem. Either:
1) There are compile errors therefore myDir was never built.
2) You are not in the directory where myDir.exe exists when you type the command.

Well it got built w/o any errors but it is NOT an .exe file--it's a .c file.

abhimanipal 91 Master Poster · Answer 5 · 2011-04-27T08:15:37+00:00

How are you compiling the program ?
There has to be a .exe file ...

yongj 1 Junior Poster in Training · Answer 6 · 2011-04-27T08:33:30+00:00

How are you compiling the program ?
There has to be a .exe file ...

Hm...my solution file is still in the ".c" extension. How can I make this into .exe? And if I do convert this into an executable file can I type myDir <filename.ext> to get <filename.ext> as an argument into the solution code?

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 7 · 2011-04-27T08:42:49+00:00

You have to use a compiler to convert the solution *.c file into *.exe file. You can not execute *.c files. There are at least two good free compilers for the MS-Windows operating system: Code::Blocks and VC++ 2010 Express. Choose either one you want, but you might find Code::Blocks a little easier to learn.

MyDir is not the name of an executable program, but just the name of the directory that contains the *.c files you want to list.

yongj 1 Junior Poster in Training · Answer 8 · 2011-04-27T08:52:55+00:00

You have to use a compiler to convert the solution *.c file into *.exe file. You can not execute *.c files. There are at least two good free compilers for the MS-Windows operating system: Code::Blocks and VC++ 2010 Express. Choose either one you want, but you might find Code::Blocks a little easier to learn.
MyDir is not the name of an executable program, but just the name of the directory that contains the *.c files you want to list.

Well my solution (".c") file is named myDir. If I compiled this into an .exe couldn't I run it by calling myDir <filename.ext> ? And I have Visual Studio 2010, could I compile it into an exe through visual studio to make it into an .exe?

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 9 · 2011-04-27T09:16:28+00:00

yes you can compile it with that compiler. Do if you have MyDir.exe then you would type on the command line MyDir c:\somepath\*.c <Enter Key> I don't know what you mean by <filename.exe>.

yongj 1 Junior Poster in Training · Answer 10 · 2011-04-27T09:31:59+00:00

yes you can compile it with that compiler. Do if you have MyDir.exe then you would type on the command line MyDir c:\somepath\*.c <Enter Key> I don't know what you mean by <filename.exe>.

By saying <filename.ext> I'm just using that as a placeholder for a file name. And it was .EXT (extension) not .exe (executable).

Any idea how to compile a .c to an .exe with visual studio? Cause I am clueless.

Ancient Dragon 5,243 Achieved Level 70 Team Colleague Featured Poster · Answer 11 · 2011-04-27T09:41:25+00:00

Ancient Dragon 5,243 Achieved Level 70

15 Years Ago

Tutorial here.

Directory Listing

Dani AI

Recommended Answers Collapse Answers

All 15 Replies

Recommended Answers