Hello C++ experts

Question

RonKevin 0 Newbie Poster

13 Years Ago

//Ok so here's my plan so far please check if i'm on the right track guys! thanks!
#include<iostream.h>
#include<cstring.h>
#include<conio.h>
struct BuyerInfo
{
 int id;
 string fn;
 string mn;
 string ln;
 string ad;
};BuyerInfo info;
void menu()
{
 cout<< "\n================================================================================";
 cout<< "\t\t\n                          WELCOME BUYER!Please fill in the following\n";
 cout<< "\n================================================================================";
 cout<< "\nBuyer's ID:B";
 cin>>info.id;
 cout<< "Enter First Name:";
 cin>>info.fn;
 cout<< "Enter Middle Name:";
 cin>>info.mn;
 cout<< "Enter Last Name:";
 cin>>info.ln;
 cout<< "Enter Adress:";
 cin>>info.ad;
}
void main()
{
 char ans;
 int buyid;
 cout<< "\n================================================================================";
 cout<< "\t\t      Welcome to the Black order Grocery system\n";
 cout<< "\n================================================================================";
 cout<< "\nPlease choose from the following:";
 cout<< "\n[A]New user";
 cout<< "\n[B]Already a member";
 cout<< "\n================================================================================";
 cout<< "Answer:";cin>>ans;
 clrscr();
    if(ans=='A'||ans=='a')
        {
          menu();
        }
    else
      cout<<"Please Enter BuyerID:";
      cin>>buyid;
}
//as you can see my program would ask the user first if he or she is already registered
//if he/she is then the program would ask the user to input his BuyerId and boom! it goes to his records
//although i haven't done it i just want to tell my plan...else if he is not registered, void menu() would 
//take place..the question now is..did i do it correctly?Did the member variables on my struct got all 
//the inputs?..my last question, my project says, the program should be able to store 100 records..
//i tried putting an array size on my struct..like this but it has an error: struct BuyerInfo[100]. 
//Can anyone explain this to me?

c++

4 Contributors
7 Replies
241 Views
21 Hours Discussion Span
Latest Post 13 Years Ago Latest Post by RonKevin

Dani AI

Generated 8 Months Ago

Good direction in the original plan, but a few practical corrections and small design changes will make the program robust and portable. correctly flagged non-standard headers and the main signature; correctly clarified how a struct becomes a datatype; and 's suggestion to move off Turbo C++ is sound—Turbo uses non-standard headers and functions (for example conio.h/clrscr) that will confuse learners later.

Prefer modern headers and a container rather than a fixed global array. Example skeleton (different names used from the thread):

#include <iostream>
#include <string>
#include <vector>

struct Item { int id; std::string name; int qty; double price; };
struct Buyer { int id; std::string first, middle, last, address; std::vector<Item> cart; };

std::vector<Buyer> buyers;
buyers.reserve(100); // reserve space for 100 records

Watch input pitfalls: mixing operator>> and std::getline leaves a newline in the buffer. Use std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n') (include <limits>) after numeric reads before calling getline. Avoid void main(); use int main() and return 0.

For scanning a buyer's items, model the workflow rather than a single flat loop: 1) search or add the Buyer record (use a linear search or a map keyed by id for fast lookup); 2) present item entry (enter product id, quantity, price); 3) push the Item into the buyer's cart; 4) compute totals and optionally write the buyer + cart to disk. For persistence, simple CSV files are easiest for beginners; later move to structured formats (JSON) or binary if needed. If constrained to Turbo C++, test file I/O carefully—behavior differs from modern compilers.

Keep functions small (e.g., addBuyer, findBuyerById, scanItemsForBuyer, saveToFile) and avoid globals where possible. This will make the program easier to extend (search, edit records, save/load).

All 7 Replies

WaltP 2,905 Posting Sage w/ dash of thyme

13 Years Ago

1) Stop putting your question into your code. Your question is not code.

2) #include<conio.h> -- don't use this. It's not standard and is not necessary.

3)

struct BuyerInfo
{
 int id;
 string fn;
 string mn;
 string ln;
 string ad;
};BuyerInfo info;

Why is the first semicolon in this line: };BuyerInfo info;?? And indent the fields more.

4) void menu() -- main is and always has been an int.

5) void main() -- twice? That's bad.

6) You don't define your array on the structure name. The array goes on the variable name.

Eagletalon 34 Junior Poster in Training

13 Years Ago

uhm... WaltP, point 4 on your list is not "main" but "menu"... and I believe it can be void...

and the semicolon in point 3 is an end while the rest should just be spaced into a new line as an variable of the struct (I hope I said it right)

Ron Walt is correct on his points though he seems very irritated and quick to show out problems, thats the general coder way, try making your code easier to read and please dont be afraid of open lines and indentation... eg:

struct BuyerInfo
{
    int id;
    string fn;
    string mn;
    string ln;
    string ad;
};

BuyerInfo info;

and now, see BuyerInfo as a "datatype"... info as a variable of that type...

how would you create an array of 100 integers? apply the same

Reply to this topic

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.

RonKevin 0 Newbie Poster · Answer 1 · 2012-09-28T12:12:57+00:00

oopss.thanks alot...so sorry about that mr.waltp....btw, im using turbo c++ 4.5 compiler..and yea its outdated...I just started reading structs...this is what i get for missing the lesson in my class..thanks for the information

Eagletalon 34 Junior Poster in Training · Answer 2 · 2012-09-28T12:26:44+00:00

cool man... give it a try, see how it goes, and if you manage just remember to mark the thread as solved

np complete 8 Newbie Poster · Answer 3 · 2012-09-28T13:38:37+00:00

@ Ron Kevin

As you already said that turbo is outdated, why don't you change to something new and "trendy" ;) Like Code::blocks, its a very nice IDE and has MinGW compiler.

WaltP 2,905 Posting Sage w/ dash of thyme Team Colleague · Answer 4 · 2012-09-28T19:32:15+00:00

uhm... WaltP, point 4 on your list is not "main" but "menu"... and I believe it can be void...

Yep, read it too fast. Sorry.

and the semicolon in point 3 is an end while the rest should just be spaced into a new line as an variable of the struct (I hope I said it right)

I suppose so... But if you weren't even sure ;)

Ron Walt is correct on his points though he seems very irritated

Don't make snap judgements about people's states of mind. Keep your opinions to yourself in regard to mental states. You don't want to put a bad ligth on a member for no reason, and it's quite close to a rules violation.

and quick to show out problems,

Should I have waited an hour? ;o)

RonKevin 0 Newbie Poster · Answer 5 · 2012-09-29T06:42:55+00:00

Hello I'm back guys! ....can't do anything about it dude, its what we use in our school...and Im from the Philippines...when I master this compiler, i'll switch..

So here it is my work so far...Record of 100 Buyers..Please check if I did it right..It worked for me so..yea..

#include<iostream.h>
#include<cstring.h>
#include<conio.h>


struct BuyerInfo
{
 int id;
 string fn;
 string mn;
 string ln;
 string ad;
}
 info[100];

void menu()
{int i=0;
 cout<< "\n================================================================================";
 cout<< "\t\t\n                          WELCOME BUYER!Please fill in the following\n";
 cout<< "\n================================================================================";
 for(i=0; i<1; i++)
 {
  cout<< "\nBuyer's ID:B";
  cin>>info[i].id;
  cout<< "Enter First Name:";
  getline(cin,info[i].fn);
  cout<< "Enter Middle Name:";
  getline(cin,info[i].mn);
  cout<< "Enter Last Name:";
  getline(cin,info[i].ln);
  cout<< "Enter Address:";
  getline(cin,info[i].ad);
}
  clrscr();
  cout<<"\n----------Data---------\n";
     for(i=0; i<1; i++)
     {
        cout<< "\nBuyer's ID:B"<<info[i].id;
        cout<< "\nFirst Name:"<<info[i].fn;
        cout<< "\nMiddle Name:"<<info[i].mn;
        cout<< "\nLast Name:"<<info[i].ln;
        cout<< "\nAdress:"<<info[i].ad;
     }
}


void main()
{
 char ans;
 int buyid;
 struct BuyerInfo info[100];
 cout<< "\n================================================================================";
 cout<< "\t\t      Welcome to the Black order Grocery system\n";
 cout<< "\n================================================================================";
 cout<< "\nPlease choose from the following:";
 cout<< "\n[A]New user";
 cout<< "\n[B]Already a member";
 cout<< "\n================================================================================";
 cout<< "Answer:";cin>>ans;
 clrscr();
    if(ans=='A'||ans=='a')
        {
          menu();

        }
    else
      cout<<"Please Enter BuyerID:";
      cin>>buyid;

}

How is it?...
Question: Now i'll go ahead and make the scan Buyer's items..any suggestions?

I hate memories but instead I want reality, A reality where I exist, and you are here next to me

Hello C++ experts

Dani AI

Recommended Answers Collapse Answers

All 7 Replies

Recommended Answers