Member Avatar for birinci2012 
def isPrime(num,div=2):
    if(num==div):
        return True
    elif(num % div == 0):
        return False
    else:
        return isPrime(num,div+1)
  • 3 Contributors
  • 2 Replies
  • 995 Views
  • 7 Hours Discussion Span
  • Latest Post Latest Post by slate
Member Avatar for Gribouillis

Probably the worst isPrime() function I've ever seen. If num is above 1000000, you are going to stack 1000000 recursive calls ! Python comes with a recursion limit

>>> import sys
>>> sys.getrecursionlimit()
1000

which means that your code will fail. The limit can be changed, but in every day programming, it does not need to.

There is no question in your post. Is it a code snippet ?

Edited by Gribouillis
Member Avatar for slate

Yes, it is worse then the infamous:

not re.match(r"^1?$|^(11+?)\1+$", "1" * number_to_test)

birinci:
There is nothing wrong with this algo. But computers (more precisely: functions using stack in the operating system) are not built the way, they can process this program efficiently. It is a leaking abstraction. Google it.

Edited by slate because: some remarks
commented: ugly code :) +14
Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.