Counetrfeit Coin Game

Not bad...

Here are some possible things you could consider for improvements:

------------------
Because coinval is a #define it should be in all caps. And while you're at it, define the heavy and light values too:

#define COINVAL 2
#define COINHEAVY 3
#define COINLIGHT 1

Also, make the values for typeOfCounterfeit into #defines as well:

#define TYPELIGHT 'L'
#define TYPEHEAVY 'H'
#define TYPEANY   'A'

These changes remove the need to use hard coded values in the code itself and you can make modifications very quickly and accurately by not searching through the code.

------------------
The function gameInfo() might be better named gameInitialize()

------------------
If you want to limit the number of coins to 12,
1) test for invalid values
2) don't make the array dynamic -- it's a waste of time and you won't need the delete

------------------
At the prompt "Press (H) for heavy counterfeit, (L) for light\n and (A) for computer to decide : ", what happens if you press K, or h, or a? Test for valid values.

------------------
All but the calls at the bottom of gameGenerate() could be put into gameInitialize() since it's all initialization.

------------------
The calls to srand() should ideally be placed at the top of main(), and only once.

------------------
For the test of typeOfCounterfeit you can use a switch(). It would make that section of code more compact.
Another option to testing 3 possibilities for typeOfCounterfeit is test for 'A' then use rand() to change it to 'L' or 'H', then do the test.

------------------
For 'A', why get a random number from 0-9 and test %2? Why not get a random number 0-1 (rand() % 2) and test if 0 or 1?

------------------
The calls at the bottom of gameGenerate() should be placed in main().
gameGenerate() sets up the game, so it shouldn't play the game.

------------------

In general, whitespace is your friend. Use it more. Compare these lines:

while(j<pan1)
if(sum1>sum2)
if((answer-1)==counterfeitCoin)
else if(typeOfCounterfeit=='A') // random counterfeit coin

with these:

while (j < pan1)
if (sum1 > sum2)
if ((answer - 1) == counterfeitCoin)
else if (typeOfCounterfeit == 'A')        // random counterfeit coin

Note the readability is better.

------------------

In playGame() you ask for number of coins in pan 1 and 2, then loop for inputs for unknown (to the user) reasons. You never tell us what these inputs are for. And you blindly wait and the user has no idea the program is waiting for input. We think the program crashed. Instead of:

    j=0;
    while(j<pan2)
    {
        cin>>input2[j];
        j++;
    }

You probably want something like:

    j=0;
    cout << "Which coins? " << endl ;
    while(j<pan2)
    {
        cout << "Enter coin number " << j+1 << ":" ;
        cin>>input2[j];
        j++;
    }

------------------

Just some ideas to think about.

Thanks waltP for reading my code and for all these suggestions. I will definitely make these changes.

The calls to srand() should ideally be placed at the top of main(), and only once.

Is this necessary ? I mean will my code run improperly? Would be please elaborate. Thanks.

The calls to srand() should ideally be placed at the top of main(), and only once.

Is this necessary ? I mean will my code run improperly? Would be please elaborate. Thanks.

Yes. srand() initializes the random generator. It does not need to be initialized more than once. The way you have them now it's probable that the two initializations will happen within the same second. That guarantees the same random numbers.

So, if you call srand() at exactly 10:53:20 and get 10 random numbers you might get
1 5456 812 32700 1325 54 622 29953 2 9834

If all that takes less than 1 second, your next call will happen at 10:53:20 and the next 10 random numbers will be:
1 5456 812 32700 1325 54 622 29953 2 9834

Not very random, eh?
So calling srand() must be done only once at or near the beginning of the program -- at the top of main() or in an initialization function that is guaranteed to be called only when the program starts.

Try this:

#include <iostream>
#include <cstdlib>
#include <ctime>
using namespace std;

int main()
{
    int rnd;
    int i;
    int j;

    for (j=0; j<4; j++)
    {
        srand(time(NULL));
        cout << "Test #" << j << ":  ";
        for (i=0; i<12; i++)
            cout << rand() << " ";
        cout << endl;    
    }

    return 0;
}

Then move the srand() outside the loop and run it again.