Member Avatar for schoolboy2010

I have this script that is supposed to check if a number the user guesses is the same as the randomly generated number.
Problem is that the random number generated at the start of the program keeps on changing everytime I click on the "Check if I'm right" button, the random number gets generated again and I never ever get to reach the correct answer.
Could someone please help/advise on what's wrong?

Thanks.


HTML CODE

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> 
<head>
  <title>Number Guessing Game</title>
  <link rel="stylesheet" href="style.css" type="text/css" />
  <script type="text/javascript" src="script.js"></script>
</head> 
 <body class="body">
  
  <div class="header">
	 Number Guessing Game
  </div>
  <div class="main">
  <div class="content">
	<p>
	  <img src="numbers.jpg" height="200px" width="278px" alt="Number guessing game graphic" />
	</p>
	<p>
	  Guess what number I am thinking of:
	<form onsubmit="javascript:guessed(); return false;">
      Type in a number between 1 and 10: <br />
	  <input type="text" name="guess" id="guess" /><br />
      <input type="text" name="output" id="output" /><br />
      <input type="submit" value="Check if I'm right" />
    </form>
	</p>
	
  </div>
  </div>
  <div class="footer">
	  <p>Copyright &copy; 2011 Number Guessing Game. <a href="mailto:tonye@brown.com">Report an issue :D</a>
	  </p>
  </div>
  
 </body>
</html>

Javascript code

function guessed() 
{
	var number = (Math.random() * 9) + 1;
	var guessField = document.getElementById('guess');
	var choice = guessField.value;
	
	var win = 0;
	
	while (win == 0)
	{
		if (choice > number)
		{
			var output = document.getElementById('output');
			output.value = 'Guess lower';
			win = 0;
		}
		else if (choice < number)
		{
			var output = document.getElementById('output');
			output.value = 'Guess higher';
			win = 0;
		}
		else
		{
			var output = document.getElementById('output');
			output.value = 'Correct, you win!';
			win = 1;
		}
		
		return false;
	}
}
  • 3 Contributors
  • 3 Replies
  • 218 Views
  • 13 Hours Discussion Span
  • Latest Post Latest Post by schoolboy2010
Member Avatar for urtrivedi

1) Modify your script as given below. You can not generate number all time user press button. Instead you must generate number only once, outside the function.

2) Also random number generated is float, so you must round it to match properly

var number = Math.round((Math.random() * 9) )+ 1;

function guessed() 
{
	
	var guessField = document.getElementById('guess');
	var choice = guessField.value;
	
	var win = 0;
	
	while (win == 0)
	{
		if (choice > number)
		{
			var output = document.getElementById('output');
			output.value = 'Guess lower';
			win = 0;
		}
		else if (choice < number)
		{
			var output = document.getElementById('output');
			output.value = 'Guess higher';
			win = 0;
		}
		else
		{
			var output = document.getElementById('output');
			output.value = 'Correct, you win!';
			win = 1;
		}
		
		return false;
	}
}
Member Avatar for roshan_iiita

Generate random value once in a session or untill the user reached upto the right answer
use pageload event for the purpose

Member Avatar for schoolboy2010

1) Modify your script as given below. You can not generate number all time user press button. Instead you must generate number only once, outside the function.

2) Also random number generated is float, so you must round it to match properly

var number = Math.round((Math.random() * 9) )+ 1;

function guessed() 
{
	
	var guessField = document.getElementById('guess');
	var choice = guessField.value;
	
	var win = 0;
	
	while (win == 0)
	{
		if (choice > number)
		{
			var output = document.getElementById('output');
			output.value = 'Guess lower';
			win = 0;
		}
		else if (choice < number)
		{
			var output = document.getElementById('output');
			output.value = 'Guess higher';
			win = 0;
		}
		else
		{
			var output = document.getElementById('output');
			output.value = 'Correct, you win!';
			win = 1;
		}
		
		return false;
	}
}

Thanks a lot... that solved the problem.

And to anyone wondering what the solution is, I put the random number generator into Math.floor() and yeah, woohooo, my javascript is working perfect now.

Be a part of the DaniWeb community

We're a friendly, industry-focused community of developers, IT pros, digital marketers, and technology enthusiasts meeting, networking, learning, and sharing knowledge.